refactor: use forge lint over solhint and adjust code accordingly
#63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x-r4bbit
commented
Nov 10, 2025
| [lint] | ||
| lint_on_build = false # Since we are using our own linting solution, we can disable built in one | ||
| exclude_lints = ["mixed-case-variable", "mixed-case-function"] | ||
| ignore = ["src/utils/ERC20VotesUpgradeable.sol"] |
Member
Author
There was a problem hiding this comment.
Reasoning for the above:
- I've excluded mixed case rules for variables and functions because we have plenty of usages were we don't want to use mixed case intentionally (upgradeable
__init()functions being one example). - I've ignored
ERC20VotesUpgradeablebecause it violates many of the linting rules but is 99% library code we don't really maintain (we just changed one line in that contract)
| "verify:emergency_mode": "certoraRun certora/confs/EmergencyMode.conf", | ||
| "verify:karma": "certoraRun certora/confs/Karma.conf", | ||
| "lint:sol": "forge fmt --check && pnpm solhint {script,src,test,certora}/**/*.sol", | ||
| "lint:sol": "forge fmt --check && forge lint", |
Member
Author
There was a problem hiding this comment.
CI and pnpm lint now uses forge lint
| if (!hasRole(DEFAULT_ADMIN_ROLE, msg.sender) && !hasRole(OPERATOR_ROLE, msg.sender)) { | ||
| revert Karma__Unauthorized(); | ||
| } | ||
| _onlyAdminOrOperator(msg.sender); |
Member
Author
There was a problem hiding this comment.
Modifier functionality has been moved into internal functions, because otherwise, the logic gets inlined into every function where the modifier is used.
| uint256 claimedBitIndex = index % 256; | ||
| uint256 claimedWord = claimedBitMap[epoch][claimedWordIndex]; | ||
| uint256 mask = (1 << claimedBitIndex); | ||
| uint256 mask = (BITMAP_MASK_BASE << claimedBitIndex); |
Member
Author
There was a problem hiding this comment.
This change is to avoid a warning that one might have swapped the two operands.
| external | ||
| view | ||
| returns (bool); | ||
| } |
Member
Author
There was a problem hiding this comment.
This one I've removed because it's not used anywhere
| return(0, 0x20) | ||
| } | ||
| } | ||
| } |
Member
Author
There was a problem hiding this comment.
The verifier is also not used anywhere.
0x-r4bbit
force-pushed
the
refactor/forge-lint
branch
from
4c3e85e to
d99e526
Compare
3esmit
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.