(enhance) Adds LocalService Option to Connect-NexusServer #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steviecoaster
requested changes
Feb 28, 2025
JPRuskin
force-pushed
the
addConfigurationLookup
branch
2 times, most recently
from
066f931 to
7d4a946
Compare
JPRuskin
force-pushed
the
addConfigurationLookup
branch
from
7d4a946 to
4cde29c
Compare
This new parameter adds the ability to connect to a service running on the local machine. It adds several private functions that look up if a local service exists, and then a -LocalService switch to the Connect-NexusServer function that uses the calculated values. This should allow people to more reliably connect locally, without forgetting interesting switches.
v2 of the action was deprecated, and now causes build failures. For further details, see: https://github.blog/changelog/2024-02-13-deprecation-notice-v1-and-v2-of-the-artifact-actions/ Fixes a GitVersion Issue in the build, where the shallow checkout of the repository was causing GitVersion to fail. Finally, adds a quick VSCode task to build the module.
Updates Invoke-Nexus to accept additional headers where appropriate. +semver:feature
Some blank output has been noticed from the responses to Invoke-Nexus. This change captures that output in a $null=.
Also, skips attempting to push the package if you don't have a Chocolatey API Key set.
Given the default page size of 10 results, Get-NexusAsset was returning a maximum of 20 results. This change fixes that, so it will continue returning matching assets until it runs out of continuation tokens.
Due to the SYSTEM user not having a profile, splitting the path failed pretty hard. This change warns the user if they are attempting to install using the system user.
Some errors were bubbling up unacceptably. This adds some handling such that a "correct" error (e.g. a 404, role not found) will respect EAP.
steviecoaster
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally enhances:
Bugfixes:
I'm happy to drop the
Captures blank-line output from a bunch of functionscommit if you'd prefer (though I find the lack of useless output tidier) - when I was analysing things that were different between NexuShell and the functions we had in QSG, I found the following stuff:I brought the changes across where appropriate, though only the $null catching stuff needed changes (beyond the addition of various functions.
I have not migrated the
Invoke-NexusScriptfunction, as it's not currently being used in QSG and simply combined the functinality of a few other functions that are already present.