Skip to content

Conversation

@prathmesh-stripe
Copy link
Contributor

Why?

Add some tests as followup to #3223

What?

  • Add test to serialize and deserialize basic object with System.Text.Json
  • Add serialization+deserialization test for Newtonsoft that has null fields assigned to non-nullable fields.

See Also

@prathmesh-stripe prathmesh-stripe requested a review from a team as a code owner October 15, 2025 16:18
@prathmesh-stripe prathmesh-stripe requested review from xavdid-stripe and removed request for a team October 15, 2025 16:18
Copy link
Contributor

@jar-stripe jar-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think combining this with #3158 ?

@prathmesh-stripe prathmesh-stripe enabled auto-merge (squash) October 16, 2025 23:06
@prathmesh-stripe prathmesh-stripe merged commit 828e8ab into master Oct 16, 2025
8 checks passed
@prathmesh-stripe prathmesh-stripe deleted the prathmesh/add-stj-test branch October 16, 2025 23:07
jar-stripe added a commit that referenced this pull request Oct 21, 2025
* update doc link (#3212)

* Improve event notification example (#3217)

* improve events example

* update docs

* added .net 9 to target frameworks
excluded deprecated code in SystemNetHttpClient for .net 9 and above
added justfile and script to install required sdk versions
updated test commands to use .net 9 target (in justfile)
deleted global.json
updated build step in ci to read target frameworks from the project file

* Revert "added .net 9 to target frameworks"

This reverts commit 26a197a.

* fixed STJDefaultConverter to advance the reader even if the property is not known (#3223)

changed loop to a filter call for clarity

* Added STJ tests for deserializing null values (#3224)

* Add support for building on .NET 9 (#3222)

---------

Co-authored-by: David Brownman <[email protected]>
Co-authored-by: Prathmesh Ranaut <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants