-
Notifications
You must be signed in to change notification settings - Fork 471
✨(backend) allow to create a new user in a marketing system #1707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
We want to create a new user in a marketing system to create a dedicated onboarding for each of them. The marketing service is implemented in the django-lasuite library and it is possible to pick the backend we want or implement a new one following the documentation on this library.
f6ea02c to
85700d5
Compare
| LASUITE_MARKETING = { | ||
| "BACKEND": values.Value( | ||
| "lasuite.marketing.backends.dummy.DummyBackend", | ||
| environ_name="LASUITE_MARKETING_BACKEND", | ||
| environ_prefix=None, | ||
| ), | ||
| "PARAMETERS": values.DictValue( | ||
| default={}, | ||
| environ_name="LASUITE_MARKETING_PARAMETERS", | ||
| environ_prefix=None, | ||
| ), | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any references in the tests about LASUITE_MARKETING, should we add a doc about how it is working ?
| } | ||
|
|
||
| # Marketing and communication settings | ||
| SIGNUP_NEW_USER_TO_MARKETING_EMAIL = values.BooleanValue( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add them in https://github.com/suitenumerique/docs/blob/main/docs/env.md.
qbey
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't you need a management command to add existing users from admin?
Purpose
We want to create a new user in a marketing system to create a dedicated
onboarding for each of them. The marketing service is implemented in the
django-lasuite library and it is possible to pick the backend we want
or implement a new one following the documentation on this library.
Proposal
Fixes #1464