Skip to content

Fix gesture preview crash on macOS 12 #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aaronkollasch wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix gesture preview crash on macOS 12 #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 8 additions & 18 deletions prefpane/MAAttachedWindow.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,24 +330,14 @@ - (void)_updateBackground

- (NSColor *)_backgroundColorPatternImage
{
NSImage *bg = [[NSImage alloc] initWithSize:[self frame].size];
NSRect bgRect = NSZeroRect;
bgRect.size = [bg size];

[bg lockFocus];
NSBezierPath *bgPath = [self _backgroundPath];
[NSGraphicsContext saveGraphicsState];
[bgPath addClip];

// Draw background.
[_MABackgroundColor set];
[bgPath fill];
//[bgPath stroke];

[NSGraphicsContext restoreGraphicsState];
[bg unlockFocus];

return [NSColor colorWithPatternImage:[bg autorelease]];
// TODO: Consider restoring old visual style
// using imageWithSize:flipped:drawingHandler e.g.:
/*
NSImage *bg = [NSImage imageWithSize:[self frame].size
flipped:NO
drawingHandler:???];
*/
return [NSColor lightGrayColor]; // Return static color for now.
}


Expand Down