-
Notifications
You must be signed in to change notification settings - Fork 314
fix: improve network restrictions update logic #4420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
maxmetcalfe
wants to merge
13
commits into
supabase:develop
Choose a base branch
from
maxmetcalfe:network-restrictions-update
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix: improve network restrictions update logic #4420
maxmetcalfe
wants to merge
13
commits into
supabase:develop
from
maxmetcalfe:network-restrictions-update
+127
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 19432739386Details
💛 - Coveralls |
sweatybridge
requested changes
Nov 11, 2025
Contributor
sweatybridge
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would be a breaking change for those who rely on the current behaviour. Could you introduce a new --append flag to the update command instead?
Author
|
thanks @sweatybridge. updated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
API improvement
What is the current behavior?
Currently, running
network-restrictions updatewill replace all existing restrictions with the provided list. This makes it easy to wipe all existing restrictions when adding a new one.What is the new behavior?
network-restrictions updatewill now add the provided restrictions to the existing list. This matches the behavior of the "Add restriction" in the Supabase UI.