Removed tokenizer builder abstraction #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er. Made loader/builder terminology more consistent.
mikob
force-pushed
the
removed-tokenizer-builder-abstraction
branch
from
98d1c30 to
09913ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
TokenizerBuilderdidn't do anything significant, so I removed that layer of abstraction to simplify things. I also renamed the builder to be loader, and the dictionary builder to be builder. This is at least more consistent, and I think easier to understand.I realize this is a bit forward, sorry for not asking permission first, but still hoping it makes sense/you accept 😺