Skip to content

Bugfix/delete deprecation #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yu1ro wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Bugfix/delete deprecation #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e08808
apply s4mohdhafiz PR
yu1ro Apr 10, 2025
919c80c
delete registerWith method.
yu1ro Aug 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,15 @@ group 'io.github.tastelessjolt.flutterdynamicicon'
version '1.0-SNAPSHOT'

buildscript {
ext.kotlin_version = '1.9.10'
repositories {
google()
jcenter()
}

dependencies {
classpath 'com.android.tools.build:gradle:3.5.1'
classpath 'com.android.tools.build:gradle:8.1.4'
classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
}
}

Expand All @@ -20,14 +22,25 @@ rootProject.allprojects {
}

apply plugin: 'com.android.library'
apply plugin: 'kotlin-android'

android {
namespace "io.github.tastelessjolt.flutterdynamicicon"

compileSdkVersion 31
compileSdkVersion 34

compileOptions {
sourceCompatibility JavaVersion.VERSION_17
targetCompatibility JavaVersion.VERSION_17
}

kotlinOptions {
jvmTarget = '17'
}

defaultConfig {
minSdkVersion 16
namespace "io.github.tastelessjolt.flutterdynamicicon"
minSdkVersion 23
testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
}
lintOptions {
Expand Down
2 changes: 1 addition & 1 deletion android/gradle/wrapper/gradle-wrapper.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-6.5-all.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-8.0-all.zip
3 changes: 1 addition & 2 deletions android/src/main/AndroidManifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
package="io.github.tastelessjolt.flutterdynamicicon">
<manifest xmlns:android="http://schemas.android.com/apk/res/android">
</manifest>
5 changes: 0 additions & 5 deletions ...id/src/main/java/io/github/tastelessjolt/flutterdynamicicon/FlutterDynamicIconPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,6 @@ public class FlutterDynamicIconPlugin implements FlutterPlugin {
private static final String CHANNEL_NAME = "flutter_dynamic_icon";
private MethodChannel channel;

@SuppressWarnings("deprecation")
public static void registerWith(io.flutter.plugin.common.PluginRegistry.Registrar registrar) {
final FlutterDynamicIconPlugin plugin = new FlutterDynamicIconPlugin();
plugin.setupChannel(registrar.messenger(), registrar.context());
}

@Override
public void onAttachedToEngine(FlutterPlugin.FlutterPluginBinding binding) {
Expand Down
4 changes: 2 additions & 2 deletions pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ repository: https://github.com/tastelessjolt/flutter_dynamic_icon
issue_tracker: https://github.com/tastelessjolt/flutter_dynamic_icon/issues

environment:
sdk: '>=2.12.0 <3.0.0'
flutter: '>=2.0.0'
sdk: ">=3.1.3 <4.0.0"
flutter: ">=3.16.4"

dependencies:
flutter:
Expand Down