Skip to content

Temporal: Add tests for a non-ISO-calendar edge case with leap years and differencing #4636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
+31 −0
Draft

Temporal: Add tests for a non-ISO-calendar edge case with leap years and differencing #4636

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions test/intl402/Temporal/PlainDate/prototype/since/leap-year-since.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
// Copyright (C) 2025 Igalia, S.L. All rights reserved.
// This code is governed by the BSD license found in the LICENSE file.

/*---
esid: sec-temporal.plaindate.prototype.since
description: Subtracting a date in a leap year from a date in a common year should work
includes: [temporalHelpers.js]
features: [Temporal]
---*/

const calendar = 'chinese';
const a = new Temporal.PlainDate(2016, 7, 31, calendar);
const b = new Temporal.PlainDate(2017, 7, 31, calendar);
TemporalHelpers.assertDuration(b.since(a, { largestUnit: 'years' }),
0, 12, 0, 11, 0, 0, 0, 0, 0, 0);
16 changes: 16 additions & 0 deletions test/intl402/Temporal/PlainDate/prototype/until/leap-year-until.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
// Copyright (C) 2025 Igalia, S.L. All rights reserved.
// This code is governed by the BSD license found in the LICENSE file.

/*---
esid: sec-temporal.plaindate.prototype.until
description: Subtracting a date in a leap year from a date in a common year should work
includes: [temporalHelpers.js]
features: [Temporal]
---*/

const calendar = 'hebrew';
const a = new Temporal.PlainDate(1967, 2, 28, calendar);
const b = new Temporal.PlainDate(1968, 3, 1, calendar);
TemporalHelpers.assertDuration(a.until(b, { largestUnit: 'years' }),
0, 12, 0, 13, 0, 0, 0, 0, 0, 0);