feat: improve how to use resource_group in modules

[posquit0]

Summary

Update resource group configuration to use object-based pattern.

Changes

• Update module version from ~> 0.10.0 to ~> 0.12.0
• Replace individual resource_group_* variables with single object variable
• Update all references to use var.resource_group.* structure
• Add resource_group output to each module

Modules Updated

• kms-key
• secrets-manager-secret
• ssm-parameter-store-parameter
• ssm-parameter-store-parameter-set

Test Plan

• Review variable changes
• Verify resource-group module references are correct
• Check outputs are properly formatted

[gemini-code-assist]

Summary of Changes

Hello @posquit0, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the way resource group configurations are handled across several Terraform modules. The primary goal is to streamline variable definitions and usage by transitioning from multiple individual variables to a single, comprehensive object-based variable. This change enhances consistency and maintainability, making it easier to manage resource group settings within these modules.

Highlights

• Module Version Update: The resource-group module version has been updated from ~> 0.10.0 to ~> 0.12.0 across all affected modules.
• Resource Group Variable Refactoring: Individual resource_group_enabled, resource_group_name, and resource_group_description variables have been consolidated into a single resource_group object variable for improved configuration management.
• Variable Reference Updates: All internal references to resource group variables have been updated to use the new var.resource_group.* object structure.
• New Resource Group Output: A new resource_group output has been added to each module, providing details like arn and name of the created resource group, if enabled.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the resource group configuration across several modules to use a more modern object-based pattern, which is a great improvement for consistency and usability. The changes are well-implemented. I've suggested a further simplification for the new resource_group outputs to make them more robust and easier to consume by using the one() function. This ensures a consistent output structure regardless of whether the resource group is created.

[gemini-code-assist]

The logic for the resource_group output can be simplified and made more robust by using the one() function with a splat expression. This ensures the output object always has the same structure (enabled, arn, name), with arn and name being null when the resource group is not created. This is a cleaner approach than conditionally adding keys with merge().

  value = {
    enabled = var.resource_group.enabled && var.module_tags_enabled
    arn     = one(module.resource_group[*].arn)
    name    = one(module.resource_group[*].name)
  }

[gemini-code-assist]

The logic for the resource_group output can be simplified and made more robust by using the one() function with a splat expression. This ensures the output object always has the same structure (enabled, arn, name), with arn and name being null when the resource group is not created. This is a cleaner approach than conditionally adding keys with merge().

  value = {
    enabled = var.resource_group.enabled && var.module_tags_enabled
    arn     = one(module.resource_group[*].arn)
    name    = one(module.resource_group[*].name)
  }

[gemini-code-assist]

The logic for the resource_group output can be simplified and made more robust by using the one() function with a splat expression. This ensures the output object always has the same structure (enabled, arn, name), with arn and name being null when the resource group is not created. This is a cleaner approach than conditionally adding keys with merge().

  value = {
    enabled = var.resource_group.enabled && var.module_tags_enabled
    arn     = one(module.resource_group[*].arn)
    name    = one(module.resource_group[*].name)
  }

[gemini-code-assist]

The logic for the resource_group output can be simplified and made more robust by using the one() function with a splat expression. This ensures the output object always has the same structure (enabled, arn, name), with arn and name being null when the resource group is not created. This is a cleaner approach than conditionally adding keys with merge().

  value = {
    enabled = var.resource_group.enabled && var.module_tags_enabled
    arn     = one(module.resource_group[*].arn)
    name    = one(module.resource_group[*].name)
  }