feat(database): add ability to create a query builder from another one #1725
+285
−85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Looking good! Eventually I'd like to clean up the query builders some more, but for now this approach makes sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the ability to create a query builder from another one, by adding a new static constructor to each of them.
I had to introduce a new
SupportsWhereStatementsinterface as well to expose the bindings and model fromBuildsQuery. For the bindings, it definitely makes sense—for the model however, it could feel out of place for such an interface. But given that allBuildsQueryimplementations have one, I think it's fine?This PR was required to fix #1720