Add summary to side effect and mutable side effect #2129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuandrew
reviewed
Dec 5, 2025
Contributor
yuandrew
left a comment
yuandrew
left a comment
There was a problem hiding this comment.
Overall looks good! Left some minor feedback. Also looks like you'll need to add the new interceptor methods to the TestInterceptorCalls test
…ental, only Summary field is experimental
djeer
force-pushed
the
add-summary-to-side-effect-and-mutable-side-effect
branch
from
a6a9316 to
7ed502c
Compare
Author
|
@yuandrew Thanks for a thorough review! I've updated the PR according to your comments |
Author
|
@yuandrew sorry for pinging, but could you please re-review after minor fixes? It would be a great Christmas miracle for our team 😄 |
Contributor
|
@djeer thanks for the ping, changes look good! Looks like CI is still failing, once you fix up the test we should be good to merge |
Author
|
@yuandrew fixed, the tests passed locally on my machine, let's try again, please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #2084 in Go SDK. It is already implemented in Java SDK here temporalio/sdk-java#2699
What was changed
Very similar to what's already exists in Activities and LocalActivities.
Why?
The justification is in #2076 , it's difficult to read a timeline with 20 SideEffect's in a row.
Checklist
Closes Add support for static summary for side effects and mutable side effects #2084
How was this tested:
Local run of our application with Options parameter provided in the code
Current behaviour is not changed, just a new experimental feature, so I guess no?