Signup #66
Draft
Signup #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want the shopping list to be routed via `/list`. This commit makes that change.
This button navigates to "/signup" where a sign up form will exist.
We need to validate the user password for strength.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
So far we changed the routing so that the initial screen is a page with the option to sign up. Clicking that button routes to
/signup. The user can create a user account via Firebase.Problems:
The person has to have a user token in place to get to this auth view which needs to be addressed. It should be that if there is no token, then the user is directed to sign up or login.
There is no password strength validation yet. It should validate for at least a length of 6 characters.
We need to figure out what happens once a user has signed up. Firebase logs them in. How do we use the user object Firebase returns on sign up to get our user to the point where they can start using the app?
Related Issue
closes #59
Acceptance Criteria
Type of Changes
Updates
Before
After
Testing Steps / QA Criteria