item section updated-delete and shopping cart icons added #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 6a4c027): https://tcl-78-smart-shopping-list--pr52-dc-listpage-css-8c5y3t3k.web.app (expires Fri, 11 Oct 2024 20:26:07 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c781903507c1507075d7a974036959ddeec29c0a |
eva-lng
reviewed
Oct 4, 2024
| import { useState, useEffect } from 'react'; | ||
| import './ListItem.css'; | ||
| import { FaTrashCan } from 'react-icons/fa6'; | ||
| import { FaCartShopping } from 'react-icons/fa6'; |
Collaborator
There was a problem hiding this comment.
You can move both icon imports into one line since they are imported from the same collection
eva-lng
approved these changes
Oct 4, 2024
Collaborator
eva-lng
left a comment
eva-lng
left a comment
There was a problem hiding this comment.
The layout of the listed items works well and looks good. Since we haven't decided on colors yet I won't comment on them. A small suggestion, it might look nicer if the urgency labels are in uppercase :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have completed the styling of list items in the list view. (ListItem.jsx)
Related Issue
closes #51
Acceptance Criteria
Updates
Before
After