urgency category colors changed #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
didemydn
requested review from
Amaka202,
GrannyYetta,
eva-lng,
tataw-cl and
vivitt
|
Visit the preview URL for this PR (updated for commit ceb6e5a): https://tcl-78-smart-shopping-list--pr62-dc-category-colors-64h3chcm.web.app (expires Thu, 17 Oct 2024 19:48:21 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c781903507c1507075d7a974036959ddeec29c0a |
eva-lng
approved these changes
Oct 10, 2024
vivitt
approved these changes
Oct 11, 2024
Collaborator
vivitt
left a comment
vivitt
left a comment
There was a problem hiding this comment.
Looks good ✨
I really like the color choices! I agree with Eva that a thinner font might work better for the labels, but I love that you kept black for the font color. I think it makes the labels more legible. Nice job!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
the color scheme for urgency categories in the list view to improve clarity and user experience.
Related Issue
closes #61
Acceptance Criteria
Type of Changes
urgency category colors have been adjusted, they are more readable and compatible, selected a more pastel color.
Updates
Before
After