This repository was archived by the owner on May 6, 2025. It is now read-only.
add configurable receive timeout for POST requests #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteffenDE
commented
Apr 24, 2025
lib/mcp_proxy/sse.ex
Outdated
Comment on lines
397
to
401
| {:error, reason} -> | ||
| Logger.error("Failed to forward message #{inspect(message)}:\n#{inspect(reason)}") | ||
| # we cannot assume that the server might still answer later (for example for timeouts) | ||
| # so we don't reply. | ||
| :ok |
Collaborator
Author
There was a problem hiding this comment.
I originally wanted to reply with an error here, but it could very well be that the server actually still sends a reply later and then we would have duplicate IDs...
Collaborator
Author
There was a problem hiding this comment.
actually: as we track IDs, we can simply discard duplicate messages - changed in 344fb2d
josevalim
approved these changes
Apr 25, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.