Improvements for fastapi #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonatanklosko
commented
Oct 22, 2025
| else: | ||
| full_path = path_info | ||
|
|
||
| full_path = full_path.rstrip("/") |
Contributor
Author
There was a problem hiding this comment.
In case of FastAPI the full path is /tidewave/ at this point.
jonatanklosko
commented
Oct 22, 2025
| # so that we check the attribute on the specific model, | ||
| # otherwise we may access the attribute inherited from | ||
| # parent. | ||
| if model.__dict__.get("__abstract__", False): |
Contributor
Author
There was a problem hiding this comment.
FastAPI uses sqlmodel, which is built on top of sqlalchemy. Models inherit from SQLModel, for example Hero(SQLModel). SQLModel has __abstract__ = True, and accessing it on Hero also returns True, because it's inherited. Checking the dict works as expected (since it doesn't include inherited attributes).
josevalim
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐈