Skip to content

Reverse order of MAKEFLAGS priority #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 26, 2025
Merged

Reverse order of MAKEFLAGS priority #152

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion jemalloc-sys/build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,7 +372,10 @@ fn make_command(make_cmd: &str, build_dir: &Path, num_jobs: &str) -> Command {

if let Ok(makeflags) = std::env::var("CARGO_MAKEFLAGS") {
let makeflags = if let Ok(orig_makeflags) = std::env::var("MAKEFLAGS") {
format!("{orig_makeflags} {makeflags}")
// Prepend Cargo makeflags before externally configured makeflags
// Adding Cargo makeflags at the end was causing issues, see
// https://github.com/tikv/jemallocator/issues/92#issuecomment-3536269176.
format!("{makeflags} {orig_makeflags}")
} else {
makeflags
};
Expand Down
Loading