Skip to content

Add extra categories #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Add extra categories #86

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3b36a44
avoid mixing up name matching
tmck-code Nov 12, 2025
c4b2d55
add test for similar names
tmck-code Nov 12, 2025
65a4760
add some extra categories
tmck-code Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions src/pokedex/pokedex.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,10 +132,9 @@ func Decompress(data []byte) []byte {

func CreateNameMetadata(idx string, key string, name PokemonName, rootDir string, fpaths []string) *PokemonMetadata {
entryCategories := make(map[int][][]string, 0)

for i, fpath := range fpaths {
basename := strings.TrimPrefix(fpath, rootDir)
if strings.Contains(basename, strings.ToLower(name.Slug)) {
if strings.Contains(basename, "/"+strings.ToLower(name.Slug)+"-") || strings.Contains(basename, "/"+strings.ToLower(name.Slug)+".") {
data, err := os.ReadFile(fpath)
Check(err)
cats := createCategories(strings.TrimPrefix(fpath, rootDir), data)
Expand Down Expand Up @@ -173,6 +172,17 @@ func createCategories(fpath string, data []byte) []string {
parts := strings.Split(fpath, "/")
height := sizeCategory(len(strings.Split(string(data), "\n")))

extra := []string{"hisui", "galar", "totem", "gmax", "alola", "mega"}

nameParts := strings.Split(
strings.TrimSuffix(parts[len(parts)-1], ".cow"),
"-",
)
for _, ex := range extra {
if nameParts[len(nameParts)-1] == ex {
return append([]string{height, ex}, parts[0:len(parts)-1]...)
}
}
return append([]string{height}, parts[0:len(parts)-1]...)
}

Expand Down
13 changes: 13 additions & 0 deletions test/data/cows/similar_names/gen7x/mew.cow
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
 ▄▄▄▄▄▄▄
▄▄▄▄▄ ▄▄▄▀
▄▄▄▄▄▀▀▀▀▀▀
 ▄▄▀ ▄▄
▀▄▄▄▄▄▄▄▄▄▄▄▄
▀▀ ▄ ▄ ▄ ▄▄▄
  ▄  ▄▄  ▄▄▄▄▄▄▄▄
 ▄ ▄▄▄▄▄▄▄▀▀▀▄▄ 
▀▄▄▀ ▄▄▄▄▄▄▀    
      ▄▄▄▄▄▄▄▀
 ▄ ▄▄▄▄▄▄▄▀▀
▀▀  ▄▄ 
▀▀
12 changes: 12 additions & 0 deletions test/data/cows/similar_names/gen7x/mewtwo.cow
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
 ▄▄  ▄▄ ▄▄
▄▄▄▄▄▄▄ ▄  ▄▄  
▄▄ ▄▄ ▄  ▄▄ ▄▀
▀▄   ▄▄  ▄▄    
 ▄▄ ▄▄▄▄▀▄▄   ▄ 
▄▄▄▄▄  ▄▄▄▄▀ ▀▄ ▄▄
  ▄▄▄▄▄▄▄ ▄ ▄▄▄▄▄  
   ▄ ▄▄   ▄▄  ▄▀
▄▄ ▄▄▄▄▄▄▄▄▄▄▄▀▀
▀▄▄▄▀ ▀▄▄▄▄
 ▄▄▄▄ 
▀▀▀▀
28 changes: 28 additions & 0 deletions test/data/cows/similar_names/gen8/eternatus-eternamax.cow
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
 ▄ ▄▄▄▄▄ ▄▄▄▄▄ ▄▄
▄▄   ▄▄▄ ▄▄▄▄▄▄ ▄▄▄▄▄  
▄▄  ▄▄▄ ▄▄▄▄▄▄▄▄▄▀▀▄▄▄▄▄▄▄ ▄▄▄▄
▄▄ ▄▄▄▄▀▀▀▀ ▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ▀▀▀▀▀
 ▄▄▄ ▄▄ ▄▄▀▀▄▄▄▄▄▄▄▄▄▄ ▄▄▄▄ ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄
▀▄ ▄▄▄ ▄▀▄▄▄▄ ▄▄▄▄▄ ▄▄▄▄
▀▄ ▄▀▄▄ ▄▄▄▄▄▀▀▀▀▀▀▀▀▀ ▄ ▄▀▀▀▀▀▄▄▄▄▄ ▄▀
▀▄  ▄▄ ▄▀▀ ▄▄   ▄▄▄▄▄▄▄ ▄ ▄▄▄▄▄▄▄ ▄▄ ▀▀▀▄▄ ▄▄
▄▄▄    ▄▄ ▄▄ ▄▄▄▄  ▄▄ ▄▄ ▄▄▄ ▄▄▄▄▄▄▄▄▄ ▀▄ ▄▄▄
▀▄ ▄▄ ▄▄▄ ▄▄▄▄▄▄ ▄▄▄▄▄ ▄▄▄▀▀▀▀▀ ▄▄▄ ▄ ▄▄▄   ▄▄
▀▀▄▄ ▄   ▄▄▄▄ ▄▄  ▄▄▄▄▄▀ ▄▄▄▄ ▄▀ ▀▄ ▄ ▄▄▀
▄▄   ▄▄▄▄▄▄ ▄ ▄▄  ▄▄▄  ▄▄▄▄ ▄ ▄▄▄▄▄▄▄▄ ▄▀▄  
  ▄▄ ▄ ▄▄▄▄▄▄▄  ▄▄▄▄▄▄▄ ▄▄ ▄▄ ▄▄▄ ▄ ▄ ▄▀▀▀▄▄ ▄▀
▄▄▄▄▄▄▄▄▄▄▄▄ ▄▄ ▄▄▄▄▄▄ ▄ ▄▄ ▄▄ ▄▄▄▄ ▄▄ ▄▄▄▄▀▀ ▄▄  
▄▄▄▄▄ ▄▄ ▄▄▄▄▄▄▄▄▄ ▄▄▄ ▄▄   ▄▄▄▄▄  ▄▀▀ ▄▄▄▄ ▄▀▀▀
▄▄▄▄▄ ▄▀▀▄▄▄ ▄▀▄▄  ▄ ▄ ▄▄▄▄▄▄ ▄ ▄▄▄▄  ▄   ▄▄▄▄▄▄ ▄ ▄▀
▄▄▄▄▄▀▀       ▄   ▄▄ ▄▄▄▄▄▄ ▄▄ ▄▄   ▀▄▄▄▄▀▄▄▀ ▀▀
▀▀ ▄ ▀▄ ▄▄  ▄ ▄ ▄▄ ▄ ▄ ▄▄    ▄▀
  ▄▄ ▄▄ ▄ ▄▄▄▄▄▄ ▄▄ ▄▄▄ ▄  ▀
 ▄▄   ▄▄▄▄  ▄▀▀▄ ▄▄▄▄▄     ▄▄▄
  ▄▄▄▄▄ ▄▄▀▀▀ ▀▀▄ ▄▀▀▄▄▄▄ ▄   
▄▄▄▄ ▄▀▀ ▀   ▄   ▄▀
 ▄▄▄▀   ▄▄▄ ▄ 
 ▄▀▀  ▄▄▄  ▄▀
   ▄▄
   ▄▄▀
  ▄▀
▀▄▀
Loading
Loading