impl Sync for RouterIntoService #3552
Closed
+5
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jplatte
requested changes
Nov 11, 2025
Member
jplatte
left a comment
jplatte
left a comment
There was a problem hiding this comment.
Sounds like we should adjust the PhantomData we use. Definitely don't want to add this unsafe impl. I'll look into this soon(-ish).
Member
|
A different fix has been merged in #3555. I'll probably make another patch release with that, soon. |
Author
|
Ah nice, that looks great, thank you very much 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an unsafe impl of Sync for RouterIntoService
Motivation
Whilst trying to build some testing apparatus for my project, I wanted to pass a reference to something containing
RouterIntoService<Body>by reference into an async method. Doing so made theFuturefor that method notSend, becauseRouterIntoService<Body>was notSync. This was problematic for me, so I looked into your source and found that the body typeBwas only held onto as aPhantomData, which to my mind means it shouldn't affect theSync-ness of the data structure. Looking further into the state typeS, that looks like it's used in a dyn trait bound who's super traits already forceSendandSync, so I believe there's not a requirement onSto beSynchere either, but I might be mistaken on that.Solution
I just added a manual implementation to relax the
!Syncconstraint on the type. This should mean that in the future I don't need to manually annotate the types in my code.