Update to rand 0.9 #215
Update to rand 0.9 #215
Conversation
Cargo.toml
Outdated
| indexmap = "2" | ||
| rand = { version = "0.8.5", features = ["small_rng"] } | ||
| rand_distr = "0.4.3" | ||
| rand = { version = "0.9", features = ["small_rng"] } |
There was a problem hiding this comment.
I'm a little fuzzy on cargo resolver. Will this break consumers who also declare a dependency on 0.8?
There was a problem hiding this comment.
This seems a breaking change as rand updated rand_core and rand_core::RngCore is exposed at the Builder::build_with_rng.
https://docs.rs/turmoil/0.6.5/turmoil/struct.Builder.html#method.build_with_rng
There was a problem hiding this comment.
Let's stash this one and we can bundle it when we go to 0.7?
There was a problem hiding this comment.
Since we're going to have a breaking change anyway, can we consider removing rand from the public API? Instead of taking an rng value, could the builder take a seed instead? That's what tokio does as well. That would allow us to freely upgrade rand going forward, and it would also remove the need for the separate build_with_rng method.
Edit: I've put up an implementation of that proposal: #246
tottoto
force-pushed
the
update-to-rand-0.9
branch
2 times, most recently
from
dcc919b to
9aa7caa
Compare
Cargo.toml
Outdated
| indexmap = "2" | ||
| rand = { version = "0.8.5", features = ["small_rng"] } | ||
| rand_distr = "0.4.3" | ||
| rand = { version = "0.9", features = ["small_rng"] } |
There was a problem hiding this comment.
| rand = { version = "0.9", features = ["small_rng"] } | |
| rand = "0.9" |
small_rng is the default now!
tottoto
force-pushed
the
update-to-rand-0.9
branch
from
9aa7caa to
5fc52b4
Compare
tottoto
force-pushed
the
update-to-rand-0.9
branch
from
5fc52b4 to
064c0f6
Compare
3 participants
Updates to rand 0.9.