Skip to content

Conversation

@ruivieira
Copy link
Member

No description provided.

mdevino and others added 24 commits April 3, 2025 09:36
Bumps [openssl](https://github.com/sfackler/rust-openssl) from 0.10.71 to 0.10.72.
- [Release notes](https://github.com/sfackler/rust-openssl/releases)
- [Commits](rust-openssl/rust-openssl@openssl-v0.10.71...openssl-v0.10.72)

---
updated-dependencies:
- dependency-name: openssl
  dependency-version: 0.10.72
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [tokio](https://github.com/tokio-rs/tokio) from 1.44.1 to 1.44.2.
- [Release notes](https://github.com/tokio-rs/tokio/releases)
- [Commits](tokio-rs/tokio@tokio-1.44.1...tokio-1.44.2)

---
updated-dependencies:
- dependency-name: tokio
  dependency-version: 1.44.2
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Add single detector tests for streaming_content_detection

Signed-off-by: Mateus Devino <[email protected]>

* Add single detector tests for streaming_classification_with_gen

Signed-off-by: Mateus Devino <[email protected]>

---------

Signed-off-by: Mateus Devino <[email protected]>
* 🔥 Remove whole doc chunking from chunker client

Signed-off-by: Evaline Ju <[email protected]>

* 🔥 Remove unused imports

Signed-off-by: Evaline Ju <[email protected]>

---------

Signed-off-by: Evaline Ju <[email protected]>
* Validate guardrails for chat_completions unary

Signed-off-by: Mateus Devino <[email protected]>

* Validate guardrails for chat_detection

Signed-off-by: Mateus Devino <[email protected]>

* Validate guardrails for classification_with_text_gen

Signed-off-by: Mateus Devino <[email protected]>

* Add non-existing detector tests for chat_completions

Signed-off-by: Mateus Devino <[email protected]>

* Add non-existing detector tests for chat_detection

Signed-off-by: Mateus Devino <[email protected]>

* Validate guardrails for context_docs_detection

Signed-off-by: Mateus Devino <[email protected]>

* Validate guardrails for detection_on_generation

Signed-off-by: Mateus Devino <[email protected]>

* Make non existing detector a constant

Signed-off-by: Mateus Devino <[email protected]>

* Validate guardrails for generation_with_detection

Signed-off-by: Mateus Devino <[email protected]>

* Validate guardrails for text_content_detection

Signed-off-by: Mateus Devino <[email protected]>

* Add guardrails validation for streaming_classification_with_gen

Signed-off-by: Mateus Devino <[email protected]>

* Add guardrails validation for streaming_content_detection

Signed-off-by: Mateus Devino <[email protected]>

* Update logs

Signed-off-by: Mateus Devino <[email protected]>

* Update src/utils.rs

Co-authored-by: Dan Clark <[email protected]>
Signed-off-by: Mateus Devino <[email protected]>

* Update src/utils.rs

Co-authored-by: Dan Clark <[email protected]>
Signed-off-by: Mateus Devino <[email protected]>

* Update src/utils.rs

Co-authored-by: Dan Clark <[email protected]>
Signed-off-by: Mateus Devino <[email protected]>

* Update src/utils.rs

Co-authored-by: Dan Clark <[email protected]>
Signed-off-by: Mateus Devino <[email protected]>

* Update src/utils.rs

Co-authored-by: Dan Clark <[email protected]>
Signed-off-by: Mateus Devino <[email protected]>

* Apply changes requested

Signed-off-by: Mateus Devino <[email protected]>

* Remove unneded conditionals

Signed-off-by: Mateus Devino <[email protected]>

---------

Signed-off-by: Mateus Devino <[email protected]>
Signed-off-by: Mateus Devino <[email protected]>
Co-authored-by: Dan Clark <[email protected]>
* Remove duplicate chat_completions test file

Signed-off-by: Mateus Devino <[email protected]>

* Build mocktail from main

Signed-off-by: Mateus Devino <[email protected]>

* Drop unnecessary clone and vec! calls for mocks

Signed-off-by: Mateus Devino <[email protected]>

* Clone duplicate mocks

Signed-off-by: Mateus Devino <[email protected]>

* Build mocktail from latest main

Signed-off-by: Mateus Devino <[email protected]>

* Add orchestrator error 500 helper

Signed-off-by: Mateus Devino <[email protected]>

* More orchestrator error helper functions

Signed-off-by: Mateus Devino <[email protected]>

* Update tests/common/errors.rs

Co-authored-by: Evaline Ju <[email protected]>
Signed-off-by: Mateus Devino <[email protected]>

* Move imports below copyright notice

Signed-off-by: Mateus Devino <[email protected]>

* Remove get_ prefix from helper functions

Signed-off-by: Mateus Devino <[email protected]>

* Replace generics with &str

Signed-off-by: Mateus Devino <[email protected]>

* Make helper functions part of OrchestratorError

Signed-off-by: Mateus Devino <[email protected]>

* Remove unneeded constants

Signed-off-by: Mateus Devino <[email protected]>

* Rename chunker error

Signed-off-by: Mateus Devino <[email protected]>

---------

Signed-off-by: Mateus Devino <[email protected]>
Signed-off-by: Mateus Devino <[email protected]>
Co-authored-by: Evaline Ju <[email protected]>
* To support s390x Signed-off-by: Sanketha CR [email protected]

Signed-off-by: Sanketha <[email protected]>

* Update Dockerfile

Updated Docker file removed elif block and updated with else condition

Co-authored-by: Dan Clark <[email protected]>
Signed-off-by: Sanketha-Cr <[email protected]>

---------

Signed-off-by: Sanketha <[email protected]>
Signed-off-by: Sanketha-Cr <[email protected]>
Co-authored-by: root <[email protected]>
Co-authored-by: Dan Clark <[email protected]>
* ✨✅ Initial chat completions batcher

Signed-off-by: Evaline Ju <[email protected]>

* ♻️✅ Chat completions batcher with out-of-order chunks

Signed-off-by: Evaline Ju <[email protected]>

* ✅ Different choice chunks test

Signed-off-by: Evaline Ju <[email protected]>

* 🧪 Detection batch test

Signed-off-by: Evaline Ju <[email protected]>

* 🧪 Switch chunk ordering

Signed-off-by: Evaline Ju <[email protected]>

* 🧪 Reverse chunk order to non-edge case

Signed-off-by: Evaline Ju <[email protected]>

* 💡 Add unit tests comments on edge case

Signed-off-by: Evaline Ju <[email protected]>

* 🎨💡 Clean up debug

Signed-off-by: Evaline Ju <[email protected]>

* 🔀 Merge with main

Signed-off-by: Evaline Ju <[email protected]>

* Update src/orchestrator/types/detection_batcher/chat_completion.rs

Co-authored-by: Dan Clark <[email protected]>
Signed-off-by: Evaline Ju <[email protected]>

* 🏷️ Add ChoiceIndex type

Signed-off-by: Evaline Ju <[email protected]>

* ♻️ Use ChoiceIndex

Co-authored-by: Dan Clark <[email protected]>
Signed-off-by: Evaline Ju <[email protected]>

* ✅ Update tests with ChoiceIndex

Signed-off-by: Evaline Ju <[email protected]>

---------

Signed-off-by: Evaline Ju <[email protected]>
Co-authored-by: Dan Clark <[email protected]>
* 🥅 Handle unsupported media type errors

Signed-off-by: Evaline Ju <[email protected]>

* ♻️ Use mutable headers

Signed-off-by: Evaline Ju <[email protected]>

* ♻️ Use HeaderValue

Signed-off-by: Evaline Ju <[email protected]>

---------

Signed-off-by: Evaline Ju <[email protected]>
…endpoint (foundation-model-stack#388)

* 🐛🔧 Allow input detection on text generation

Signed-off-by: Evaline Ju <[email protected]>

* ✅ Valid whole doc input detection test

Signed-off-by: Evaline Ju <[email protected]>

---------

Signed-off-by: Evaline Ju <[email protected]>
…ation-model-stack#392)

* Implement re-try logic for TestOrchestratorServer port binding

Signed-off-by: Mateus Devino <[email protected]>

* Match ioError specifically

Signed-off-by: Mateus Devino <[email protected]>

* Apply changes requested on PR

Signed-off-by: Mateus Devino <[email protected]>

---------

Signed-off-by: Mateus Devino <[email protected]>
* Drop Batch associated type from DetectionBatcher and generics, drop detector_id from DetectionStream, integrate single detection stream optimization

Signed-off-by: declark1 <[email protected]>

* Update DetectionBatchStream docstring

Signed-off-by: declark1 <[email protected]>

---------

Signed-off-by: declark1 <[email protected]>
…el-stack#383)

* Add content validation

Signed-off-by: Mateus Devino <[email protected]>

* Add no_detectors tests for chat completions

Signed-off-by: Mateus Devino <[email protected]>

* Add empty content message test for chat completions

Signed-off-by: Mateus Devino <[email protected]>

* Add comments about changing validation

Signed-off-by: Mateus Devino <[email protected]>

* Update chat completions passthrough tests for empty message

Signed-off-by: Mateus Devino <[email protected]>

* Add further validation for empty content

Signed-off-by: Mateus Devino <[email protected]>

* Test case: passthrough with last message as an array

Signed-off-by: Mateus Devino <[email protected]>

* Prevent content array on last message when input detector is present

Signed-off-by: Mateus Devino <[email protected]>

* nit: combine if clauses

Signed-off-by: Mateus Devino <[email protected]>

---------

Signed-off-by: Mateus Devino <[email protected]>
@ruivieira ruivieira added the enhancement New feature or request label Jun 5, 2025
@ruivieira ruivieira moved this to In Review in TrustyAI planning Jun 5, 2025
Copy link

@evaline-ju evaline-ju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ruivieira ruivieira merged commit 3a65afc into main Jun 9, 2025
1 check passed
@ruivieira ruivieira moved this from In Review to Done in TrustyAI planning Jun 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

8 participants