-
Notifications
You must be signed in to change notification settings - Fork 769
polario-frame:1.0.0 #3473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
polario-frame:1.0.0 #3473
Conversation
|
|
||
| Rendering result | ||
|
|
||
|  |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you write a better image description. Something like "A page displaying the same photograph with four different frames, showing the camera settings, brand and the date in different styles" would work. This will allow people using screen readers or with a poor internet connection to picture themselves what the result will look like.
Also, it would be better to used a "pinned" link, by replacing main with a commit hash or git tag, so that the image still corresponds to the output of the package as it was in this version, even if you make modifications to your repository later on. This remark applies to all links to your repository in general.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated the image description and swapped the links to a specific commit hash.
Really appreciate the pointers!
| same "printed page" as the copyright notice for easier | ||
| identification within third-party archives. | ||
|
|
||
| Copyright [yyyy] [name of copyright owner] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line should be updated with proper information.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the reminder, added.
a64e9cc to
3f14e30
Compare
|
Looks good, thank you. |
I am submitting
Description:
classic-bottom-twoclassic-bottom-threeclassic-right-twoclassic-right-threepolaroid-bottom-twopolaroid-bottom-threepolaroid-right-twopolaroid-right-threeframescropI have read and followed the submission guidelines and, in particular, I
typst.tomlfile with all required keysREADME.mdwith documentation for my packageLICENSEfile or linked one in myREADME.mdexcluded PDFs or README images, if any, but not the LICENSE