-
Notifications
You must be signed in to change notification settings - Fork 777
tvcg-journal:0.0.1 #3534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
tvcg-journal:0.0.1 #3534
Conversation
Removed development instructions and related sections from README.
elegaanz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this package! I have left a few remarks, but overall it looks good to me.
|
|
||
| <p align="center"><img src="thumbnail.png" width="500"/></p> | ||
|
|
||
| Live [preview of the PDF template](https://domoritz.github.io/tvcg-journal-typst/main.pdf). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would recommend linking to your repository here (or to a copy of main.pdf that you would ship with this package). This will allow to keep the demonstration PDF in sync with the current package version, by including the commit hash or tag name in the URL.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. The PDF is <300kb at this point so I think it's okay to include it in each release but exclude it from downloads.
| @@ -0,0 +1,17 @@ | |||
| [package] | |||
| name = "tvcg-journal" | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this template is official, can some member of the journal staff send an email stating so to [email protected]? If not, I will ask you to change the name to something that is not the canonical name. You can read our naming guidelines if you need more details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not yet but I am working with the folks from TVCG to see whether we can make it official. Maybe we can transfer the repo to https://github.com/ieeevgtc to make it official.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you didn't take this picture yourself and/or it is under a different license as the rest of the package, can you please specify it at the end of your README (or some other place).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's from https://github.com/ieeevgtc/tvcg-journal-latex/blob/main/figs/CypressView.jpg.
https://github.com/ieeevgtc/vgtc_conference_latex/blob/fa8a0b485983d6908a7151656952cfc31087bd59/template.tex#L354C33-L354C104 says "Scott Miller / Special to the Vancouver Sun, January 22, 2009, page A6."
I am submitting
A template for TVCG journals and the IEEE VIS Conference. The package source code is at https://github.com/domoritz/tvcg-journal-typst.
I have read and followed the submission guidelines and, in particular, I
typst.tomlfile with all required keysREADME.mdwith documentation for my packageLICENSEfile or linked one in myREADME.mdexcluded PDFs or README images, if any, but not the LICENSE