Set default WebRTC policy, add default settings documentation #2359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
networkException
approved these changes
May 28, 2023
Member
networkException
left a comment
networkException
left a comment
There was a problem hiding this comment.
Minor nit, I think these could be separate commits, all good otherwise
Contributor
Author
|
I'm not sure why I didn't make them separate commits in retrospect. |
networkException
approved these changes
May 30, 2023
Contributor
|
Do I get it right: it is supposed to supersede #1845 and it is a part it it? Will we be dealing with licensing demarcation somehow someday? |
Contributor
Author
|
Yup! This shouldn't run into any licensing issues as far as I'm aware. |
PF4Public
approved these changes
Jun 10, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets the WebRTC IP handling policy to disable non-proxied UDP by default. This also introduces new documentation for the default settings changed by ungoogled-chromium.
The WebRTC IP handling policy can be changed with the existing
--webrtc-ip-handling-policyswitch and #1687 adds an entry in chrome://flags.This default may no longer be necessary if mDNS is re-enabled in #2116.