-
Notifications
You must be signed in to change notification settings - Fork 17
Improve editor config for two indentation files #1661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Improve editor config for two indentation files #1661
Conversation
xml and xaml based language files should not be provided with 2 indent spaces but when edited with using of tab or HD add 4 spaces. That disturbed the layout in the file messes up when using copilot completion accepting ect
…pear on Windows host VS2022 in the templates in the future
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes indentation configuration issues in the .editorconfig file that were causing inconsistent formatting when editing XML, XAML, and related files. The changes consolidate multiple file type configurations and address end-of-line warnings on Windows.
- Consolidates scattered file type configurations into unified rules with consistent 2-space indentation
- Removes end-of-line enforcement for XML, XAML, and JSON files to prevent Windows compatibility issues
- Standardizes indentation style to spaces across multiple file types
| ########################################## | ||
|
|
||
| [*.{yml,yaml}] | ||
| [*.{xaml,xml,yml,yaml,slnf,sln,csproj,proj,projitems,shproj,props,targets,appxmanifest,json,html,cshtml,webmanifest,manifest,css,vsconfig,sh,md,markdown}] |
Copilot
AI
Jul 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR title contains a spelling error: 'intendation' should be 'indentation'. This same terminology issue appears to be reflected in the configuration grouping.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in the configuration grouping I would not see this wrong spelled. Updated the title either way. rewording the branch would cancel the whole PR, which seems like unrequired trouble.
| indent_size = 4 | ||
| indent_style = tab |
Copilot
AI
Jul 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The plist file configuration conflicts with the consolidated rule above. Plist files are included in the consolidated rule with 2-space indentation, but this specific rule sets 4 spaces, creating inconsistent behavior.
| indent_size = 4 | |
| indent_style = tab | |
| indent_size = 2 | |
| indent_style = space |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not seeing conflict. above is only group set, that all of them are getting the lf eol, but the size and styling are only set for plist down here.
Co-authored-by: Copilot <[email protected]>
|
@jeromelaban beside the spelling issue in the branch name or title (fixed) I would not see the comments of Copilot beeing reasoned. would you check on this? |
|
would not know how this PR should cause problems on MvvmAuthOidc like in the Test run, most likely thats caused from something else. |
GitHub Issue (If applicable): closes #1501
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
unset eol for xml xaml and json, so the eol warnings may disappear on Windows host VS2022 in the templates in the future
update indent_size and indent_style settings
xml and xaml based language files should not be provided with 2 indent spaces but when edited with using of tab or HD add 4 spaces. That disturbed the layout in the file messes up when using copilot completion accepting ect.
PR Checklist
Please check if your PR fulfills the following requirements:
Other information
there might be other related open issues (HD) which could be helped with this as a base config thats already messing the styling up is not very helpful if you want to build on it (sand compared to rocks ;) )
Internal Issue (If applicable):