Skip to content

Conversation

@DevTKSS
Copy link
Contributor

@DevTKSS DevTKSS commented Jul 19, 2025

GitHub Issue (If applicable): closes #1501

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

  • unset eol for xml xaml and json, so the eol warnings may disappear on Windows host VS2022 in the templates in the future
  • editing xml and xaml files in my app with by default using tab for intending was resulting in 4 intentendations instead of the actually pre provided 2 space intendations in all of them (also props and targets and csproj files!) which of course does resulting of this messing up when I were using intellicode suggestions, copilot or Hot Design Feature. If they are correctly behaved looking at the editorconfig, I were not expecting this configuration and got annoyed from the time having to spend to delete the not wanted intendations.

What is the new behavior?

  • unset eol for xml xaml and json, so the eol warnings may disappear on Windows host VS2022 in the templates in the future

  • update indent_size and indent_style settings

    xml and xaml based language files should not be provided with 2 indent spaces but when edited with using of tab or HD add 4 spaces. That disturbed the layout in the file messes up when using copilot completion accepting ect.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Associated with an issue (GitHub or internal)

Other information

there might be other related open issues (HD) which could be helped with this as a base config thats already messing the styling up is not very helpful if you want to build on it (sand compared to rocks ;) )

Internal Issue (If applicable):

DevTKSS added 2 commits July 19, 2025 16:50
xml and xaml based language files should not be provided with 2 indent spaces but when edited with using of tab or HD add 4 spaces. That disturbed the layout in the file messes up when using copilot completion accepting ect
…pear on Windows host VS2022 in the templates in the future
Copilot AI review requested due to automatic review settings July 19, 2025 15:19
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes indentation configuration issues in the .editorconfig file that were causing inconsistent formatting when editing XML, XAML, and related files. The changes consolidate multiple file type configurations and address end-of-line warnings on Windows.

  • Consolidates scattered file type configurations into unified rules with consistent 2-space indentation
  • Removes end-of-line enforcement for XML, XAML, and JSON files to prevent Windows compatibility issues
  • Standardizes indentation style to spaces across multiple file types

##########################################

[*.{yml,yaml}]
[*.{xaml,xml,yml,yaml,slnf,sln,csproj,proj,projitems,shproj,props,targets,appxmanifest,json,html,cshtml,webmanifest,manifest,css,vsconfig,sh,md,markdown}]
Copy link

Copilot AI Jul 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR title contains a spelling error: 'intendation' should be 'indentation'. This same terminology issue appears to be reflected in the configuration grouping.

Copilot uses AI. Check for mistakes.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the configuration grouping I would not see this wrong spelled. Updated the title either way. rewording the branch would cancel the whole PR, which seems like unrequired trouble.

Comment on lines 33 to 34
indent_size = 4
indent_style = tab
Copy link

Copilot AI Jul 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The plist file configuration conflicts with the consolidated rule above. Plist files are included in the consolidated rule with 2-space indentation, but this specific rule sets 4 spaces, creating inconsistent behavior.

Suggested change
indent_size = 4
indent_style = tab
indent_size = 2
indent_style = space

Copilot uses AI. Check for mistakes.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not seeing conflict. above is only group set, that all of them are getting the lf eol, but the size and styling are only set for plist down here.

@DevTKSS DevTKSS changed the title Improve editor config for two intendation files Improve editor config for two indentation files Jul 19, 2025
@DevTKSS
Copy link
Contributor Author

DevTKSS commented Jul 19, 2025

@jeromelaban beside the spelling issue in the branch name or title (fixed) I would not see the comments of Copilot beeing reasoned. would you check on this?
I would not know how to test templates locally easily...

@DevTKSS
Copy link
Contributor Author

DevTKSS commented Jul 26, 2025

would not know how this PR should cause problems on MvvmAuthOidc like in the Test run, most likely thats caused from something else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug][6.0 SolutionTemplates] (Again...) New Uno App all xaml have EOL issues after creation

1 participant