Skip to content

Feat/flash-backup-implementation #1409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 56 commits into
base: main
Choose a base branch
from
Draft

Feat/flash-backup-implementation #1409

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
56 commits
Select commit Hold shift + click to select a range
d31d86d
feat: add rclone
elibosley Apr 15, 2025
8df0ca5
chore: progress on rclone
elibosley Apr 15, 2025
f93c850
chore: rclone config almost complete
elibosley Apr 15, 2025
242697c
feat: ui working for RClone setup
elibosley Apr 15, 2025
4c9e004
chore: more progress on generative ui
elibosley Apr 16, 2025
0be56f1
chore: renderer fixes
elibosley Apr 16, 2025
35a6d14
fix: storybook
elibosley Apr 16, 2025
bf3b95b
feat: fix storybook config
elibosley Apr 16, 2025
68139cd
chore: fix combobox
elibosley Apr 16, 2025
f5e4607
chore: more cleanup
elibosley Apr 17, 2025
dada8e6
chore: error wrapper generic
elibosley Apr 17, 2025
d3adbaf
chore: lint
elibosley Apr 21, 2025
00b1c1b
chore: don't disable apollo in dev mode
elibosley Apr 21, 2025
7be5890
chore: unit test fixes
elibosley Apr 22, 2025
54b0bc0
chore: lint
elibosley Apr 22, 2025
af5ffec
chore: refactor form label helper
elibosley Apr 22, 2025
93d9530
feat: add crypt one-click setup for remotes
elibosley May 3, 2025
db9b8c1
feat: rclone installed into package
elibosley May 23, 2025
a5c7b9f
Update unraid-ui/src/forms/renderers.ts
elibosley May 23, 2025
3ffde02
fix: remove rclone webUI
elibosley May 23, 2025
744f34f
fix: rclone username and password removed
elibosley May 23, 2025
8f83520
fix: rclone pretry and unnecessary escapes
elibosley May 23, 2025
64c7145
fix: invalid tester
elibosley May 23, 2025
5e9d09e
fix: review feedback
elibosley May 23, 2025
9d42499
fix: cleanup types in spec
elibosley May 23, 2025
1d3800c
fix: use DTOs for rclone api service
elibosley May 23, 2025
7c26b01
fix: some redaction and fix constructor
elibosley May 23, 2025
d83d36c
fix: logging api version as well
elibosley May 23, 2025
69b8eb9
fix: sanitize params
elibosley May 24, 2025
50b80b9
fix: format
elibosley May 24, 2025
25f57f9
fix: comment cleanup
elibosley May 24, 2025
cebca3d
fix: combobox commit on close
elibosley May 24, 2025
7f9f4c6
fix: simplify api service test
elibosley May 24, 2025
f29d4f5
fix: colors
elibosley May 24, 2025
f0c26b7
chore: remove unused comments
elibosley May 24, 2025
8befa23
fix: entropy on crypt creation
elibosley May 24, 2025
6935990
chore: begin setting up new views and mutations for flash backup
elibosley May 24, 2025
333093a
feat: setup initial backup stats
elibosley May 24, 2025
8da7c6e
feat: backups working
elibosley May 24, 2025
5b0862d
feat: substantial code cleanup
elibosley May 25, 2025
5fcb8da
feat: progress on flash backup
elibosley May 26, 2025
015c6e5
feat: substantial type cleanup
elibosley May 26, 2025
90ed4b9
feat: cleanup types
elibosley May 26, 2025
92f3d69
feat: refactor preprocessors to source
elibosley May 27, 2025
c273a3b
feat: remove stream job manager in favor of using stdin
elibosley May 27, 2025
f126c95
feat: more progress with new backup schema
elibosley May 27, 2025
87fc836
fix: monitor jobs
elibosley May 27, 2025
73ba3f0
Merge branch 'main' into feat/flash-backup-implementation
elibosley Jul 11, 2025
f99264e
chore: remove .bivvy
elibosley Jul 11, 2025
872559c
chore: build.ts removed
elibosley Jul 11, 2025
e7066c0
chore: update pnpm lock
elibosley Jul 11, 2025
a406fdc
chore: types
elibosley Jul 12, 2025
984b874
chore: type cleanup
elibosley Jul 12, 2025
0d864fa
chore: frontend functionality
elibosley Jul 12, 2025
4c0b967
refactor(test): update vitest config and improve rclone service tests
elibosley Jul 12, 2025
b663293
chore: update lint-staged and settings.local.json commands
elibosley Jul 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion .claude/settings.local.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,17 @@
"Bash(mv:*)",
"Bash(ls:*)",
"mcp__ide__getDiagnostics",
"Bash(pnpm --filter \"*connect*\" test connect-status-writer.service.spec)"
"Bash(pnpm --filter \"*connect*\" test connect-status-writer.service.spec)",
"Bash(pnpm add:*)",
"Bash(npx tsc:*)",
"Bash(pnpm list:*)",
"Bash(rm:*)",
"Bash(pnpm --filter ./api test)",
"Bash(pnpm i:*)",
"Bash(pnpm:*)",
"Bash(corepack prepare:*)",
"Bash(nvm:*)",
"Bash(git config:*)"
]
},
"enableAllProjectMcpServers": false
Expand Down
3 changes: 2 additions & 1 deletion api/.env.development
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ PATHS_ACTIVATION_BASE=./dev/activation
PATHS_PASSWD=./dev/passwd
PATHS_RCLONE_SOCKET=./dev/rclone-socket
PATHS_LOG_BASE=./dev/log # Where we store logs
PATHS_BACKUP_JOBS=./dev/api/backup
ENVIRONMENT="development"
NODE_ENV="development"
PORT="3001"
Expand All @@ -26,4 +27,4 @@ BYPASS_PERMISSION_CHECKS=false
BYPASS_CORS_CHECKS=true
CHOKIDAR_USEPOLLING=true
LOG_TRANSPORT=console
LOG_LEVEL=trace
LOG_LEVEL=debug # Change to trace for extremely noisy logging
2 changes: 1 addition & 1 deletion api/.eslintrc.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,5 +53,5 @@ export default tseslint.config(eslint.configs.recommended, ...tseslint.configs.r
'eol-last': ['error', 'always'],
},

ignores: ['src/graphql/generated/client/**/*'],
ignores: ['src/graphql/generated/client/**/*', 'scripts/**/*'],
});
25 changes: 25 additions & 0 deletions api/dev/api/backup/backup-jobs.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
[
{
"id": "a68667b6-f4ef-4c47-aec3-d9886be78487",
"name": "Test",
"sourceType": "RAW",
"destinationType": "RCLONE",
"schedule": "0 2 * * *",
"enabled": true,
"sourceConfig": {
"label": "Raw file backup",
"sourcePath": "/Users/elibosley/Desktop",
Copy link
Contributor

@coderabbitai coderabbitai bot Jul 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Use generic path for development configuration.

The hardcoded user-specific path /Users/elibosley/Desktop makes this configuration file non-portable across different development environments.

-      "sourcePath": "/Users/elibosley/Desktop",
+      "sourcePath": "/tmp/backup-test",
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"sourcePath": "/Users/elibosley/Desktop",
"sourcePath": "/tmp/backup-test",
🤖 Prompt for AI Agents 
In api/dev/api/backup/backup-jobs.json at line 11, replace the hardcoded
user-specific path "/Users/elibosley/Desktop" with a generic or relative path
that works across different development environments to improve portability of
the configuration file.

"excludePatterns": [],
"includePatterns": []
},
"destinationConfig": {
"type": "RCLONE",
"remoteName": "google_drives",
"destinationPath": "desktop"
},
"createdAt": "2025-05-27T15:02:31.655Z",
"updatedAt": "2025-05-27T15:11:40.547Z",
"lastRunAt": "2025-05-27T15:07:37.139Z",
"lastRunStatus": "Failed: RClone group backup-job_1748358397105_sbo5j322k failed or timed out."
}
]
6 changes: 4 additions & 2 deletions api/dev/configs/api.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
{
"version": "4.8.0",
"version": "4.9.5",
Copy link
Contributor

@coderabbitai coderabbitai bot Jul 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Version inconsistency detected across configuration files.

This file shows version 4.9.5 while api/dev/Unraid.net/myservers.cfg shows 4.8.0. Ensure all configuration files use consistent versioning for this release.

🤖 Prompt for AI Agents 
In api/dev/configs/api.json at line 2, the version is set to 4.9.5, which is
inconsistent with the version 4.8.0 found in api/dev/Unraid.net/myservers.cfg.
Update the version in api.json to match 4.8.0 to ensure consistent versioning
across configuration files for this release.

"extraOrigins": [
"https://google.com",
"https://test.com"
],
"sandbox": true,
"ssoSubIds": [],
"plugins": ["unraid-api-plugin-connect"]
"plugins": [
"unraid-api-plugin-connect"
]
}
2 changes: 1 addition & 1 deletion api/dev/states/myservers.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[api]
version="4.4.1"
version="4.8.0"
extraOrigins="https://google.com,https://test.com"
[local]
sandbox="yes"
Expand Down
Loading
Loading