-
Notifications
You must be signed in to change notification settings - Fork 45
Increase maximum devices per pool from 60 to 200 #385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Merge only after 7.2.1 release. This was out of date, it mentioned a 60 device pool limit. It was 120, but from 7.2.1 it's going to be 200.
📝 WalkthroughWalkthroughDocumentation update to the cache pools guide for Unraid OS. The maximum device count per pool was increased from 60 to 200 devices, and use-case descriptions were expanded with additional bullets covering pool optimization, data protection, workload isolation, and management flexibility. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/unraid-os/using-unraid-to/manage-storage/cache-pools.mdx(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: deploy-preview
🔇 Additional comments (2)
docs/unraid-os/using-unraid-to/manage-storage/cache-pools.mdx (2)
304-304: Verify AI summary claim about two change locations.The AI-generated summary states: "Updated the 'Multiple pools' section in two places to reflect a larger maximum device count per pool." However, only line 304 shows a marked change (
~) in the provided code.Please verify whether:
- A second location mentioning the device limit exists elsewhere in this file and should have been updated, or
- The AI summary is inaccurate and only one location was actually changed.
1-60: Relative file links look good.The documentation correctly uses relative paths for internal wiki links (e.g.,
./array/overview.mdx,./shares.mdx,../../advanced-configurations/optimize-storage/zfs-storage.mdx). Pre-submission checklist item appears satisfied.
|
Merge only after 7.2.1 release.
This was out of date, it mentioned a 60 device pool limit. It was 120, but from 7.2.1 it's going to be 200.
Before Submitting This PR, Please Ensure You Have Completed The Following:
Summary by CodeRabbit