-
Notifications
You must be signed in to change notification settings - Fork 46
Update removing-disks-from-array.mdx #389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughDocumentation update to the Unraid disk removal guide, refining grammar in existing instructions and adding comprehensive new steps (5–12) for the Parity-preserve method, including unmount, disk zeroing, array reset, and parity verification procedures. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes
Poem
Pre-merge checks and finishing touches❌ Failed checks (2 inconclusive)
✅ Passed checks (1 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
docs/unraid-os/using-unraid-to/manage-storage/array/removing-disks-from-array.mdx (1)
65-77: Verify device naming conventions and UI element references.The new steps (5–12) provide comprehensive instructions for the parity-preserve method. Before merging, confirm:
Device naming: Verify that the disk device naming conventions are accurate:
- Line 68:
dd bs=1M if=/dev/zero of=/dev/mdXp1for Unraid 6.12+- Line 69:
dd bs=1M if=/dev/zero of=/dev/mdXfor Unraid 6.11 and earlierThese differ from typical Linux conventions (usually
/dev/sdXor/dev/nvmeXnYp1). Confirm that Unraid uses the/dev/mdXpXnaming for RAID arrays.UI element reference: Line 75 references "Parity is already valid" checkbox. Verify this matches the exact text and location in the current Unraid UI.
Terminology: Line 62 uses "maintenance mode"—confirm this is the correct term used in the Unraid interface.
Additionally, consider enhancing the safety context: the
ddcommand on line 68–69 is destructive and irreversible. While line 56 provides a general warning, you may want to add an inline note (e.g., before line 66) reminding users to triple-check the device name before executing the command.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/unraid-os/using-unraid-to/manage-storage/array/removing-disks-from-array.mdx(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: deploy-preview
🔇 Additional comments (1)
docs/unraid-os/using-unraid-to/manage-storage/array/removing-disks-from-array.mdx (1)
62-62: Grammar improvement looks good.The change from "then stops the array" to "then stop the array" correctly uses imperative mood, which is consistent with instructional writing style throughout the document.
|
|
thanks |
typo fix
Before Submitting This PR, Please Ensure You Have Completed The Following:
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.