Skip to content

7.3 Refactor fixed listing height processing #2427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
limetech merged 3 commits into from
Dec 1, 2025
Merged

7.3 Refactor fixed listing height processing #2427

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b54bb1a
Refactor fixed listing height processing
Squidly271 Oct 16, 2025
7e88002
Fix respawning of events
Squidly271 Oct 16, 2025
9535aea
Merge branch 'master' into patch-9
Squidly271 Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 34 additions & 27 deletions emhttp/plugins/dynamix.vm.manager/VMMachines.page
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ Title="Virtual Machines"
Tag="columns"
Cond="is_file('/var/run/libvirt/libvirtd.pid')"
Markdown="false"
Focus="tableHeaderResize"
---
<?PHP
/* Copyright 2005-2023, Lime Technology
Expand Down Expand Up @@ -462,37 +463,43 @@ function loadlist() {
$('.text').click(showInput);
$('.input').blur(hideInput);
<?if (_var($display,'resize')):?>
fillAvailableHeight({
targetElementSelector: '.js-fill-available-height',
elementSelectorsForHeight: [
'.js-actions',
'#kvm_table thead',
],
elementSelectorsForSpacing: [
'#kvm_table',
],
manualSpacingOffset: 50, // without this, the main content will still be scrollable by like 20px
});
// Handle table header fixed positioning after resize
function tableHeaderResize() {
$('#kvm_table thead,#kvm_table tbody').removeClass('fixed');
$('#kvm_table thead tr th').each(function(){$(this).width($(this).width());});
$('#kvm_table tbody tr td').each(function(){$(this).width($(this).width());});
$('#kvm_table thead,#kvm_table tbody').not('.child').addClass('fixed');
}
tableHeaderResize();
$(window).bind('resize',function(){
tableHeaderResize();
});
// Handle table header resizing when tab is clicked
<?if (count($pages) > 2):?>
$("#tab1").on('click',function(){

// Handle table header resizing when window is resized with debouncing
var resizeTimeout;
$(window).off('resize.vmTableResize').on('resize.vmTableResize',function(){
clearTimeout(resizeTimeout);
resizeTimeout = setTimeout(function(){
tableHeaderResize();
});
<?endif;?>
<?endif;?>
}, 150);
});
<?endif;?>
});
}

// Handle table header fixed positioning after resize
// Only applicable to listing height: fixed
// Function needs to exist in the global scope due to "Focus" attribute in the page
function tableHeaderResize() {
<?if (_var($display,'resize')):?>
fillAvailableHeight({
targetElementSelector: '.js-fill-available-height',
elementSelectorsForHeight: [
'.js-actions',
'#kvm_table thead',
],
elementSelectorsForSpacing: [
'#kvm_table',
],
manualSpacingOffset: 50, // without this, the main content will still be scrollable by like 20px
});
$('#kvm_table thead,#kvm_table tbody').removeClass('fixed');
$('#kvm_table thead tr th').each(function(){$(this).width($(this).width());});
$('#kvm_table tbody tr td').each(function(){$(this).width($(this).width());});
$('#kvm_table thead,#kvm_table tbody').not('.child').addClass('fixed');
<?endif;?>
}

$(function() {
<?if ($msg):?>
<?$color = strpos($msg, "rror:")!==false ? 'red-text':'green-text'?>
Expand Down
Loading