Make test_file.py tests parallelizable #202
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This file takes little to no time to run as is. Your point is that with these changes, all the tests can run in parallel? |
Contributor
Author
|
@mmckerns That is exactly my point, yes. 😊 |
Contributor
|
Futureproofing! |
mmckerns
requested changes
Jan 23, 2017
Member
mmckerns
left a comment
mmckerns
left a comment
There was a problem hiding this comment.
This change is fine, in general. I'd rather not have a print in clean_artifact. It seems unnecessary, can you remove it?
Peque
force-pushed
the
pytest_parallel
branch
from
b7eb877 to
dc82f4e
Compare
Contributor
Author
|
@mmckerns Removed unnecessary print. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a small change that makes tests in
test_file.pyparallelizable. This is useful for being able to run tests in parallel withpytest(i.e.:pytest -n 8).Note that
pytest-xdistmodule is required in order to use the-noption withpytest.