Skip to content

Conversation

@gsaudade99
Copy link
Contributor

This might impose high load on the db.

xref: #1495

@gsaudade99 gsaudade99 self-assigned this Dec 5, 2025
Copilot AI review requested due to automatic review settings December 5, 2025 11:18
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enables the Gxadmin Galaxy cleanup cron task by moving it (along with the Docker cleanup task) from a host-specific configuration file to a shared maintenance configuration file, and changing its enable flag from false to true.

  • Relocated cron task definitions from group_vars/sn09/sn09.yml to group_vars/maintenance.yml
  • Enabled the gxadmin Galaxy cleanup task to run every 2 days at midnight
  • Added a clarifying comment explaining the gxadmin cleanup purpose

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
group_vars/sn09/sn09.yml Removed host-specific cron task configurations for Docker and gxadmin cleanup
group_vars/maintenance.yml Added shared cron task configurations, enabling the gxadmin Galaxy cleanup task that removes old histories/hdas

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@kysrpex
Copy link
Contributor

kysrpex commented Dec 8, 2025

I think there is something wrong with this branch..., those commits are already merged, probably needs a rebase.

@gsaudade99 gsaudade99 force-pushed the enable/gxadmin_galaxy_cleanup branch from 50b646d to 04e1d5f Compare December 8, 2025 13:54
@gsaudade99
Copy link
Contributor Author

gsaudade99 commented Dec 8, 2025

I'm not sure how to fix this ... I did merge master into the current branch locally to sync the changes, didn't know that all commits would show here =/

edit: I did rebase now but I think the commit history wont disappear (?)

@kysrpex kysrpex force-pushed the enable/gxadmin_galaxy_cleanup branch from baaaa86 to c6c19b1 Compare December 8, 2025 15:57
@kysrpex
Copy link
Contributor

kysrpex commented Dec 8, 2025

I'm not sure how to fix this ... I did merge master into the current branch locally to sync the changes, didn't know that all commits would show here =/

edit: I did rebase now but I think the commit history wont disappear (?)

I hope the state I force-pushed is the one you wanted to reach. If not git reset baaaa86 is your friend :)

@kysrpex kysrpex merged commit 134935c into usegalaxy-eu:master Dec 10, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants