redact update #16
redact update #16
Conversation
| try { | ||
| // Fetch balance from the specified CEX | ||
| const balance = (await broker.fetchFreeBalance({ | ||
| const balance = await broker.fetchFreeBalance({ |
There was a problem hiding this comment.
Oddly here, the result of fetchFreeBalance is a Balance struct.
https://github.com/usherlabs/ccxt/blob/cde501ea4d784f2c2b4809c526135719af8ad0e7/js/src/base/Exchange.d.ts#L684
How does this resolve to an array of balances?
Can we add some explaination in comments for this?
There was a problem hiding this comment.
The balance struct is incorrect
Creating a test bench to show you what I mean
There was a problem hiding this comment.
The referenced Github Issue (ccxt/ccxt#26327) appears to show that FetchBalance can return a mapping.
There was a problem hiding this comment.
approval need to correct this
usherlabs/ccxt#7
There was a problem hiding this comment.
This fix doesn't really solve the root cause of the types issue.
It just moves the any deeper into the tech stack (from CEX Broker to CCXT) — https://github.com/usherlabs/ccxt/pull/7/files#diff-217b1af2b2442a19286fc9dbdd67c6d6e3a71dd5efd78bb489d6fec0e15be25fR7430
As detailed in comment, seems to be reported here: ccxt/ccxt#26327
There was a problem hiding this comment.
yes, that was corrected in usherlabs/ccxt#7
…ands. ensure redact works per metadata instruction.
No description provided.