Skip to content

Conversation

@KanniShashankh
Copy link

@KanniShashankh KanniShashankh commented Oct 9, 2023

@KanniShashankh KanniShashankh marked this pull request as ready for review October 9, 2023 10:31
Copy link

@wess wess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please be sure to have tests for your adapter.

@gewenyu99
Copy link

@KanniShashankh Please run linters, include tests, and make sure test/build passes!

@Haimantika
Copy link

@KanniShashankh once you have worked on the tests and linters, please request a review from Wess.

@KanniShashankh KanniShashankh requested a review from wess October 26, 2023 11:36
@KanniShashankh
Copy link
Author

@wess Lint and Unit Tests work!!!!. Please review :)

@gewenyu99
Copy link

Hey,

Due to time constraints, I'm going to mark this PR hacktoberfest-accepted for now so you get DO's Hacktoberfest rewards. We'll continue to work with you on this issue for review and merge.

When it is merged, we'll contact you for Appwrite-specific Hacktoberfest swag.

Thanks for helping us improve Appwrite!

@gewenyu99
Copy link

Hey there! There were a lot of big PRs during this Hacktoberfest, and we wanted to give everyone ample time to collaborate with our engineering team. If you were able to merge your PRs during October, amazing. If it’s still not merged, don’t worry about it either. Either way, we’ve got your Hacktoberfest swag minted and ready to ship.

Please comment with your Discord username here so we can contact you about your shipping information to deliver your Hacktoberfest swag.

@KanniShashankh
Copy link
Author

@gewenyu99 my discord username is error_compiling, excited about working with the engineering team if any further changes required in the PR.

@gewenyu99
Copy link

Hey, thank you so much for you patience, I am compiling everyone's user names before reaching out. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants