du: Fix wrong output sizes when a subdirectory is included with its parent directory in the arguments #9204
+91
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arent directory in the arguments
Contributor
|
could you please add a test to make sure we won't regress? thanks |
|
GNU testsuite comparison: |
Author
|
Sure, will do it shortly |
…arent directory in the arguments Make existing inode tracking not work per-file, but rather on the whole file set, so as to avoid duplicates having their sizes counted twice. Add a test case. Additionally provide a utility empty fixture constructor for TestScenario. Test scenario by: @fedkad Issue: uutils#9202
Author
|
Uhh I guess I should split this into 3 commits, right? |
Author
|
Close this mess, make 3 clean commits, reopen PR with them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make existing inode tracking not work per-file, but rather on the whole file set, so as to avoid duplicates having their sizes counted twice.
#9202