Skip to content

Add oneDPL Public CI state and requirements. #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 17 commits into from
Closed

Add oneDPL Public CI state and requirements. #222

Changes from 2 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
b414a36
Draft of oneDPL Public CI state and requirements.
timmiesmith Apr 18, 2025
9eca457
Update oneDPL required software
timmiesmith Apr 21, 2025
61f170d
Add oneMKL info to project-ci-documentation.md (#220)
mkrainiuk Apr 22, 2025
32599dc
Addressing review comments
timmiesmith Apr 22, 2025
4b86fd4
Add information on supported NVIDIA and AMD platforms
timmiesmith Apr 22, 2025
268239f
Correct table
timmiesmith Apr 22, 2025
903f01e
introduce initial version of CI description for oneDAL (#223)
napetrov Apr 29, 2025
08fa6e1
added April's minutes (#224)
melonakos Apr 30, 2025
82082ab
Update project-infrastructure/project-ci-documentation.md
timmiesmith Apr 30, 2025
fe4d5f5
Update project-infrastructure/project-ci-documentation.md
timmiesmith Apr 30, 2025
aac8e5f
Draft of oneDPL Public CI state and requirements.
timmiesmith Apr 18, 2025
91f66db
Update oneDPL required software
timmiesmith Apr 21, 2025
0d93131
Addressing review comments
timmiesmith Apr 22, 2025
286e70a
Add information on supported NVIDIA and AMD platforms
timmiesmith Apr 22, 2025
dba3170
Correct table
timmiesmith Apr 22, 2025
cd8d670
Resolving conflicts
timmiesmith May 22, 2025
6098a30
Applying review suggesstions.
timmiesmith May 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 23 additions & 4 deletions project-infrastructure/project-ci-documentation.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,23 +78,42 @@ Representative: Timmie Smith

Support contact for CI:

| Maintainers |
| ------------------------- |
| Dan Hoeflinger @danhoeflinger |
| Dmitriy Sobolev @dmitriy-sobolev |
| Timmie Smith @timmiesmith |

*Existing public CI*
Copy link

@dmitriy-sobolev dmitriy-sobolev Apr 22, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be nice to mention how to run this CI, e.g. that it is automatically triggered in oneDPL repository when a PR is opened and a new commit is made.

Copy link
Collaborator Author

@timmiesmith timmiesmith Apr 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is too much detail for what is being requested at this time.

Copy link
Collaborator Author

@timmiesmith timmiesmith May 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.


| Owner | Type | OS | Number | Active? | How to access logs |
| --- | --- | --- | --- | --- | --- |
| ? | ? | ? | ? | ? | ? |
| GitHub | CPU x86 | Ubuntu | 11 | Yes | Via CI Testing Workflow view |
| GitHub | CPU x86 | Windows | 3 | Yes | Via CI Testing Workflow view |
| GitHub | AArch64 | Mac OS | 1 | Yes | Via CI Testing Workflow view |

*Required Public CI Infrastruture Needed To Confidently Accept Contributions*

| Instruction set architecture | Hardware Vendor | Processor Type | Operating System |
| --- | --- | --- | --- |
| x86 | Intel | CPU | Ubuntu |
| AArch64 | Arm | CPU | Ubuntu |
| Xe, Xe2, Xe3 | Intel | GPU | Ubuntu, Windows |
| | NVIDIA | GPU | Ubuntu, Windows |
| | AMD | GPU | Ubuntu, Windows |

Software Versions:
* CMake
* glibc
* ...
| Windows | Linux | MacOS (Arm CPU testing) |
Copy link

@dmitriy-sobolev dmitriy-sobolev Apr 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be more readable to have "Software" or "Tool" as a first column. The cells may contain for example: minimal version number, "any" or "-" (not needed).

Copy link
Collaborator Author

@timmiesmith timmiesmith Apr 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

version information is too much detail in my opinion.

Copy link

@dmitriy-sobolev dmitriy-sobolev Apr 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Different product on one line still bothers me (such as dpc++ compiler and clang++ compiler). I suggest making a bullet list.

You can ignore this comment though - it is a matter of taste.

Copy link
Collaborator Author

@timmiesmith timmiesmith May 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added the Software column.

| --- | --- | --- |
| CMake 3.20 | CMake 3.11 | CMake 3.11 |
| git | git | git |
| python | python | python |
| miniforge-python | miniforge-python | miniforge-python |
| DPC++ Compiler | DPC++ Compiler | clang++ compiler |
| gmake | clang++ compiler | |
| ninja | g++ | |
| Visual Studio 2019 | | |
| Visual Studio 2022 | | |

Copy link

@dmitriy-sobolev dmitriy-sobolev Apr 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should also mention the supported GPU driver and their versions. It is a yet another tool oneDPL depends on.

Copy link
Collaborator Author

@timmiesmith timmiesmith Apr 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is too much detail at this point.

Copy link
Collaborator Author

@timmiesmith timmiesmith Apr 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The question of how much detail is needed in this document was discussed in the UXL Open Source Working Group meeting. The feedback received is that any details on configurations teams can provide is useful, so I will add the details suggested.

Copy link
Collaborator Author

@timmiesmith timmiesmith May 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

oneDAL
------
Expand Down