Use queryish start/stop properties #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laymonage
reviewed
Oct 23, 2025
Member
There was a problem hiding this comment.
Works great, thanks! I think we need to bump the queryish requirement to 0.3.0 though, to ensure people who already have 0.2 installed will have it upgraded, as otherwise this will break for them:
Line 14 in 095454a
tomusher
force-pushed
the
fix/queryish-api-changes
branch
from
e087448 to
41c9ff7
Compare
laymonage
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Queryish's limit/offset are now read-only and replaced with start/stop https://github.com/wagtail/queryish/pull/8/files causing some breakage as per #3
This resolves the issue by updating the start/stop properties where appropriate.