Fix "Change homepage introduction to rich text" #411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thibaudcolas
approved these changes
Nov 21, 2025
Member
thibaudcolas
left a comment
thibaudcolas
left a comment
There was a problem hiding this comment.
All working well! A few small changes needed
| @@ -1,13 +1,14 @@ | |||
| {% extends "base.html" %} | |||
| {% load manifest wagtailimages_tags wagtailcore_tags i18n %} | |||
| {% load wagtailcore_tags %} | |||
Member
There was a problem hiding this comment.
It’s already in the line above so not needed :)
apps/core/tests/test_homepage.py
Outdated
| def setUp(self): | ||
| self.homepage = HomePageFactory() | ||
| self.homepage.introduction = ( | ||
| "<p><i>Want to learn more about Wagtail’s future?</i></p>" |
Member
There was a problem hiding this comment.
Suggested change
| "<p><i>Want to learn more about Wagtail’s future?</i></p>" | |
| f'<p>Want to learn more about <a id="{self.homepage.id}" linktype="page">Wagtail’s future</a>?</p>' |
We can get extra value here by using rich text formatting that looks different between its storage format and intended output. That way, we can check the |richtext filter is correctly being used!
thibaudcolas
force-pushed
the
change-homepage-introduction-to-rich-text-409
branch
from
2a7c9ab to
7a54fba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This
HomePage.introductionfield into awagtail.model.fields.RichTextField<div>,Fixes: #409