Skip to content

Release v5.25.0 #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Release v5.25.0 #321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b8aa655
Add support for Chrome Beta and Chrome Canary
jasongill Oct 23, 2024
0e3a21a
Merge pull request #320 from jasongill/feature/add-chrome-beta-and-ca…
alanhamlett Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions WakaTime/Helpers/MonitoringManager.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ class MonitoringManager {
fatalError("\(monitoredApp.rawValue) should never use window title as entity")
case .canva:
fatalError("\(monitoredApp.rawValue) should never use window title as entity")
case .chrome:
case .chrome, .chromebeta, .chromecanary:
fatalError("\(monitoredApp.rawValue) should never use window title as entity")
case .figma:
guard
Expand Down Expand Up @@ -287,7 +287,7 @@ class MonitoringManager {
return .browsing
case .canva:
return .designing
case .chrome:
case .chrome, .chromebeta, .chromecanary:
return .browsing
case .figma:
return .designing
Expand Down Expand Up @@ -418,7 +418,7 @@ class MonitoringManager {
switch monitoredApp {
case .canva:
return "Image (svg)"
case .chrome:
case .chrome, .chromebeta, .chromecanary:
do {
guard let url = currentBrowserUrl(for: app, element) else { return nil }

Expand Down Expand Up @@ -464,7 +464,7 @@ class MonitoringManager {
case .brave:
let addressField = element.findAddressField()
address = addressField?.value
case .chrome:
case .chrome, .chromebeta, .chromecanary:
let addressField = element.findAddressField()
address = addressField?.value
case .firefox:
Expand Down
4 changes: 4 additions & 0 deletions WakaTime/Watchers/MonitoredApp.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ enum MonitoredApp: String, CaseIterable {
case brave = "com.brave.Browser"
case canva = "com.canva.CanvaDesktop"
case chrome = "com.google.Chrome"
case chromebeta = "com.google.Chrome.beta"
case chromecanary = "com.google.Chrome.canary"
case figma = "com.figma.Desktop"
case firefox = "org.mozilla.firefox"
case github = "com.github.GitHubClient"
Expand Down Expand Up @@ -101,6 +103,8 @@ enum MonitoredApp: String, CaseIterable {
MonitoredApp.arcbrowser.rawValue,
MonitoredApp.brave.rawValue,
MonitoredApp.chrome.rawValue,
MonitoredApp.chromebeta.rawValue,
MonitoredApp.chromecanary.rawValue,
MonitoredApp.firefox.rawValue,
MonitoredApp.safari.rawValue,
MonitoredApp.safaripreview.rawValue,
Expand Down
Loading