feat: Reliable Channel: Status Sync, overflow protection, stop TODOs #2729
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem / Description
Various improvements for reliable channels based on developer feedback as well as better code organisation by extracting some classes.
Solution
ReliableChannel.syncStatusthat emit events and information on missing messagesReliableChannel.stopto ensure there are no hanging timeout, intervals, retries or subscriptionssetInterval,clearInterval) being modified and not restored in some tests.ReliableChannelto make it leaner, and test more easily/thoroughlyNotes
For (3) @jm-clius @shash256 the spec is open to interpretation, should we update it?
TODOs:
Persistent local history is wip but probably better to do in follow-up PR
Need to cross-reference with Fix/reliable channel and node cleanup #2717 see if anything else should be done
Resolves
Related to
Checklist