fix: wakucanary now fails correctly when ping fails #3595
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can find the image built from this PR at Built from f7b10d4 |
Ivansete-status
requested review from
NagyZoltanPeter,
darshankabariya and
fcecin
Ivansete-status
force-pushed
the
fix-wakucanary-fail-pings
branch
from
c45d344 to
ac866c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: #3551
Original author: @MorganaFuture
The original PR got abruptly closed after a deep cleanup and refactor applied by this on 2025-09-30
Description
Previously reported SUCCESS even when ping failed due to connection issues. Now properly exits with error code 1 when ping fails.
Issue
closes #3546