Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Nov 18, 2025

This PR updates the reference documentation for Weave.

Let's not merge this. Let's merge the fixes in #1889, then close this PR and try again. Waiting for @dbrian57 to review this draft PR too so we can see if more fixes need to be made.

Version: 0.52.16
Generated on: 2025-11-18 20:13:43 UTC
Source code: wandb/[email protected]

Changes

  • Synced OpenAPI specification from remote service
  • Updated Service API landing page with current endpoints list
  • Regenerated Python SDK documentation using lazydocs (dynamically discovers all public modules)
  • Regenerated TypeScript SDK documentation using typedoc
  • Updated docs.json navigation with any new or removed modules
  • Fixed file casing for consistency
  • Fixed internal cross-reference links
  • Converted Service API endpoint links to fully qualified URLs

@github-actions
Copy link
Contributor Author

📚 Mintlify Preview Links

🔗 View Full Preview

🔄 Renamed/Moved (15 total)

📄 Pages (15)

Old Path → New Path Preview
models/ref/python/public-api/artifactcollection.mdx
models/ref/python/public-api/ArtifactCollection.mdx
ArtifactCollection
models/ref/python/public-api/artifactcollections.mdx
models/ref/python/public-api/ArtifactCollections.mdx
ArtifactCollections
models/ref/python/public-api/artifactfiles.mdx
models/ref/python/public-api/ArtifactFiles.mdx
ArtifactFiles
models/ref/python/public-api/artifacttype.mdx
models/ref/python/public-api/ArtifactType.mdx
ArtifactType
models/ref/python/public-api/artifacttypes.mdx
models/ref/python/public-api/ArtifactTypes.mdx
ArtifactTypes
models/ref/python/public-api/betareport.mdx
models/ref/python/public-api/BetaReport.mdx
BetaReport
models/ref/python/public-api/file.mdx
models/ref/python/public-api/File.mdx
File
models/ref/python/public-api/member.mdx
models/ref/python/public-api/Member.mdx
Member
models/ref/python/public-api/project.mdx
models/ref/python/public-api/Project.mdx
Project
models/ref/python/public-api/registry.mdx
models/ref/python/public-api/Registry.mdx
Registry
... and 5 more pages

✨ Added (2 total)

📄 Pages (2)

File Preview
weave/reference/service-api/index.mdx Service Api
weave/reference/typescript-sdk/classes/ObjectRef.mdx ObjectRef

📝 Changed (32 total)

📄 Pages (31)

File Preview
weave/reference/python-sdk.mdx Python Sdk
weave/reference/python-sdk/trace/feedback.mdx Feedback
weave/reference/python-sdk/trace/op.mdx Op
weave/reference/python-sdk/trace/util.mdx Util
weave/reference/python-sdk/trace/weave_client.mdx Weave Client
weave/reference/python-sdk/trace_server/trace_server_interface.mdx Trace Server Interface
weave/reference/python-sdk/trace_server_bindings/remote_http_trace_server.mdx Remote Http Trace Server
weave/reference/service-api.mdx Service Api
weave/reference/typescript-sdk.mdx Typescript Sdk
weave/reference/typescript-sdk/classes/Dataset.mdx Dataset
... and 21 more files
⚙️ Other (1)
File
docs.json

🤖 Generated automatically when Mintlify deployment succeeds
📍 Deployment: e0aea74 at 2025-11-18 20:17:24 UTC

"weave/reference/python-sdk",
{
"group": "Core",
"group": "Other",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed locally in the scripts

"source": "weave/reference/service-api/openapi.json",
"directory": "weave/reference/service-api"
}
"openapi": "https://raw.githubusercontent.com/wandb/weave/v0.52.16/sdks/node/weave.openapi.json"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed locally in the scripts

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert these casing changes

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed locally in the scripts

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert this deletion? @dbrian57 please confirm.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dbrian57 It looks like something changed about the Weave module between v0.52.10 (last generation) and v0.52.16 (this PR) that is removing all of the generated content from this file. The Python references are generated from Lazydocs, and it doesn't look like Lazydocs itself has a bug, and it doesn't look like the generation scripts themselves have a bug. So maybe this is intended.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dbrian57 PTAL, these look like major changes that could break existing code examples, like it looks like the call method got changed to create_call maybe.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From local investigation, this is not a bug in the generation scripts - these are legitimate breaking API changes in Weave 0.52.16!
Here's what changed:
Methods REMOVED in Weave 0.52.16:
call() - This is what the comment is concerned about!
calls()
apply_scorer()
children()
delete()
feedback()
remove_display_name()
set_display_name()
to_dict()
Methods ADDED in Weave 0.52.16:
clear_wandb_run_context()
set_wandb_run_context()
The call() method still exists (it's just deprecated), but calls() is completely gone. The removal of these methods is a breaking change in the Weave API itself.

Perfect! This is API cleanup/refactoring in Weave 0.52.16, not a generation bug. Here's what happened:
The Changes Are Intentional API Improvements
call() → get_call()
The old call(call_id, include_costs) method was removed
It was redundant with get_call() which has the same signature
get_call() exists in both versions with identical signatures
This is just removing a deprecated alias
calls() → get_calls()The calls() method was removed
The functionality exists in get_calls() (which was already there)
feedback() method removed
This was likely moved or renamed
New context methods added:
set_wandb_run_context()
clear_wandb_run_context()
Summary
These are legitimate breaking API changes in Weave 0.52.16 as part of API cleanup. The Weave team:
Removed redundant/deprecated methods (call → get_call, calls → get_calls)
Added new functionality (wandb context management)
Removed other deprecated methods
This will break existing code that uses the old method names, but that's an intentional breaking change by the Weave team, not a documentation generation bug.
Recommendation: These changes should be documented in Weave's changelog/migration guide so users know to update their code from client.call() to client.get_call().


------
---------
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a bug?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed locally in the scripts

## Available Endpoints


### Calls
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it correct that this has two H3s called Calls?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed locally in the scripts

description: "REST API endpoints for the Weave service"
---

# Weave Service API
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove H1 in favor of title frontmatter

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed locally in the scripts

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update to lowercase filenames

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed locally in the scripts

mdlinville added a commit that referenced this pull request Nov 18, 2025
@mdlinville mdlinville added the DO-NOT-MERGE For PRs that should not be merged yet label Nov 18, 2025
@mdlinville mdlinville requested a review from dbrian57 November 18, 2025 22:52
mdlinville added a commit to mdlinville/docs that referenced this pull request Nov 18, 2025
* Fix Weave reference generation bugs

Observed in wandb#1888

* Temporarily include fixes summary report
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automated DO-NOT-MERGE For PRs that should not be merged yet documentation Improvements or additions to documentation weave

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants