-
Notifications
You must be signed in to change notification settings - Fork 36
Update Weave reference documentation (Weave 0.52.16) #1888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
📚 Mintlify Preview Links🔄 Renamed/Moved (15 total)📄 Pages (15)
✨ Added (2 total)📄 Pages (2)
📝 Changed (32 total)📄 Pages (31)
⚙️ Other (1)
🤖 Generated automatically when Mintlify deployment succeeds |
| "weave/reference/python-sdk", | ||
| { | ||
| "group": "Core", | ||
| "group": "Other", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed locally in the scripts
| "source": "weave/reference/service-api/openapi.json", | ||
| "directory": "weave/reference/service-api" | ||
| } | ||
| "openapi": "https://raw.githubusercontent.com/wandb/weave/v0.52.16/sdks/node/weave.openapi.json" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed locally in the scripts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert these casing changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed locally in the scripts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert this deletion? @dbrian57 please confirm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dbrian57 It looks like something changed about the Weave module between v0.52.10 (last generation) and v0.52.16 (this PR) that is removing all of the generated content from this file. The Python references are generated from Lazydocs, and it doesn't look like Lazydocs itself has a bug, and it doesn't look like the generation scripts themselves have a bug. So maybe this is intended.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dbrian57 PTAL, these look like major changes that could break existing code examples, like it looks like the call method got changed to create_call maybe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From local investigation, this is not a bug in the generation scripts - these are legitimate breaking API changes in Weave 0.52.16!
Here's what changed:
Methods REMOVED in Weave 0.52.16:
call() - This is what the comment is concerned about!
calls()
apply_scorer()
children()
delete()
feedback()
remove_display_name()
set_display_name()
to_dict()
Methods ADDED in Weave 0.52.16:
clear_wandb_run_context()
set_wandb_run_context()
The call() method still exists (it's just deprecated), but calls() is completely gone. The removal of these methods is a breaking change in the Weave API itself.
Perfect! This is API cleanup/refactoring in Weave 0.52.16, not a generation bug. Here's what happened:
The Changes Are Intentional API Improvements
call() → get_call()
The old call(call_id, include_costs) method was removed
It was redundant with get_call() which has the same signature
get_call() exists in both versions with identical signatures
This is just removing a deprecated alias
calls() → get_calls()The calls() method was removed
The functionality exists in get_calls() (which was already there)
feedback() method removed
This was likely moved or renamed
New context methods added:
set_wandb_run_context()
clear_wandb_run_context()
Summary
These are legitimate breaking API changes in Weave 0.52.16 as part of API cleanup. The Weave team:
Removed redundant/deprecated methods (call → get_call, calls → get_calls)
Added new functionality (wandb context management)
Removed other deprecated methods
This will break existing code that uses the old method names, but that's an intentional breaking change by the Weave team, not a documentation generation bug.
Recommendation: These changes should be documented in Weave's changelog/migration guide so users know to update their code from client.call() to client.get_call().
|
|
||
| ------ | ||
| --------- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a bug?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed locally in the scripts
| ## Available Endpoints | ||
|
|
||
|
|
||
| ### Calls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it correct that this has two H3s called Calls?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed locally in the scripts
| description: "REST API endpoints for the Weave service" | ||
| --- | ||
|
|
||
| # Weave Service API |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove H1 in favor of title frontmatter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed locally in the scripts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update to lowercase filenames
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed locally in the scripts
* Fix Weave reference generation bugs Observed in wandb#1888 * Temporarily include fixes summary report
This PR updates the reference documentation for Weave.
Let's not merge this. Let's merge the fixes in #1889, then close this PR and try again. Waiting for @dbrian57 to review this draft PR too so we can see if more fixes need to be made.
Version: 0.52.16
Generated on: 2025-11-18 20:13:43 UTC
Source code: wandb/[email protected]
Changes