Skip to content

Conversation

@ngrayluna
Copy link
Contributor

@ngrayluna ngrayluna commented Jul 17, 2024

Added more context to the notebook (before I convert it to markdown). See https://wandb.atlassian.net/browse/DOCS-904

@ngrayluna ngrayluna requested a review from sephmard July 17, 2024 21:45
@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.88%. Comparing base (d656a2a) to head (53d2345).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #30   +/-   ##
=======================================
  Coverage   70.88%   70.88%           
=======================================
  Files          16       16           
  Lines        2356     2356           
=======================================
  Hits         1670     1670           
  Misses        686      686           

@ngrayluna ngrayluna changed the title Word smithing Tutorial: Named workspace polish Jul 17, 2024
@ngrayluna
Copy link
Contributor Author

@ngrayluna To do: install pre commits and resolve broken CI builds

@sephmard
Copy link

I don think we should include the notebook output. Its messy.

Copy link

@sephmard sephmard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont think that we should include the notebook output.

@ngrayluna ngrayluna requested a review from sephmard July 17, 2024 22:05
@sephmard
Copy link

Please remove output before merging

@ngrayluna ngrayluna requested a review from andrewtruong July 18, 2024 18:10
@ngrayluna ngrayluna mentioned this pull request Jul 18, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants