Skip to content

Add dimensions property to Text2VecCohereConfig and update tests #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −0
Open

Add dimensions property to Text2VecCohereConfig and update tests #366

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/collections/config/types/vectorizer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,8 @@ export type Multi2VecCohereConfig = {
imageFields?: string[];
/** The specific model to use. */
model?: string;
/** The number of dimensions for the generated embeddings. */
dimensions?: number;
/** The text fields used when vectorizing. */
textFields?: string[];
/** The truncation strategy to use. */
Expand Down Expand Up @@ -371,6 +373,8 @@ export type Text2VecCohereConfig = {
baseURL?: string;
/** The model to use. */
model?: string;
/** The number of dimensions for the generated embeddings. */
dimensions?: number;
/** Whether to truncate the input texts to fit within the context length. */
truncate?: boolean;
/** Whether to vectorize the collection name. */
Expand Down
4 changes: 4 additions & 0 deletions src/collections/configure/unit.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,6 +331,7 @@ describe('Unit testing of the vectorizer factory class', () => {
const config = configure.vectors.multi2VecCohere({
name: 'test',
model: 'model',
dimensions: 512,
imageFields: [
{ name: 'field1', weight: 0.1 },
{ name: 'field2', weight: 0.2 },
Expand All @@ -350,6 +351,7 @@ describe('Unit testing of the vectorizer factory class', () => {
name: 'multi2vec-cohere',
config: {
model: 'model',
dimensions: 512,
imageFields: ['field1', 'field2'],
textFields: ['field3', 'field4'],
weights: {
Expand Down Expand Up @@ -1002,6 +1004,7 @@ describe('Unit testing of the vectorizer factory class', () => {
name: 'test',
baseURL: 'base-url',
model: 'model',
dimensions: 512,
truncate: true,
});
expect(config).toEqual<VectorConfigCreate<never, 'test', 'hnsw', 'text2vec-cohere'>>({
Expand All @@ -1015,6 +1018,7 @@ describe('Unit testing of the vectorizer factory class', () => {
config: {
baseURL: 'base-url',
model: 'model',
dimensions: 512,
truncate: true,
},
},
Expand Down