Cookie Store API: trimming of TAB and SPACE #54211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
There are no reviewers for this pull request. Please reach out on the chat room to get help with this. Thank you! |
5 tasks
RupinMittal
approved these changes
Aug 9, 2025
| }); | ||
| const cookie = await cookieStore.delete(' cookie-name \t'); | ||
| assert_equals(cookie, undefined); | ||
| }, 'cookieStore.delete with whitespace'); |
Contributor
There was a problem hiding this comment.
Nit: Maybe 'cookieStore.delete with whitespace or tab' here and in the other places?
Or maybe is tab already considered whitespace? Maybe it's just semantics. I'm not sure, just noticed so I pointed it out--up to you :)
Member
Author
There was a problem hiding this comment.
Yeah a tab is whitespace. There are also things that are whitespace that are not a tab or space, but since it's just a test name I think it's okay.
annevk
added a commit
to whatwg/cookiestore
that referenced
this pull request
Aug 9, 2025
Also slowly start modernizing some algorithm conventions. Tests: web-platform-tests/wpt#54211. Fixes #276.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For whatwg/cookiestore#281.