Cookie Store API: empty string path defaulting #54264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
There are no reviewers for this pull request. Please reach out on the chat room to get help with this. Thank you! |
annevk
added a commit
to annevk/WebKit
that referenced
this pull request
Aug 12, 2025
https://bugs.webkit.org/show_bug.cgi?id=297268 Reviewed by NOBODY (OOPS!). Implement whatwg/cookiestore#283 with tests upstreamed at web-platform-tests/wpt#54264
5 tasks
annevk
added a commit
to annevk/WebKit
that referenced
this pull request
Aug 12, 2025
https://bugs.webkit.org/show_bug.cgi?id=297268 Reviewed by NOBODY (OOPS!). Implement whatwg/cookiestore#283 with tests upstreamed at web-platform-tests/wpt#54264
annevk
added a commit
to annevk/WebKit
that referenced
this pull request
Aug 13, 2025
https://bugs.webkit.org/show_bug.cgi?id=297268 Reviewed by NOBODY (OOPS!). Implement whatwg/cookiestore#283 with tests upstreamed at web-platform-tests/wpt#54264
annevk
added a commit
to annevk/WebKit
that referenced
this pull request
Aug 14, 2025
https://bugs.webkit.org/show_bug.cgi?id=297268 Reviewed by NOBODY (OOPS!). Implement whatwg/cookiestore#283 with tests upstreamed at web-platform-tests/wpt#54264
yoavweiss
reviewed
Aug 14, 2025
| assert_equals(internalCookie.path, currentDirectory); | ||
| }, 'CookieListItem - cookieStore.set with empty string path defaults to current URL'); | ||
|
|
||
| promise_test(async testCase => { |
Contributor
There was a problem hiding this comment.
I don't get this one, why is the cookie rejected? Doesn't this pose some back-compat risk?
Member
Author
There was a problem hiding this comment.
It rejects in Chrome today. The reason is that the path becomes /cookiestore and it has to be / for a __host--prefixed cookie.
Contributor
There was a problem hiding this comment.
Thanks! Optionally, it might be worthwhile to add a comment to that effect.
annevk
added a commit
to whatwg/cookiestore
that referenced
this pull request
Aug 14, 2025
Also correct the algorithm as it incorrectly assumed that path could be null when in fact it's always a string. Tests: web-platform-tests/wpt#54264. Closes #242.
webkit-commit-queue
pushed a commit
to annevk/WebKit
that referenced
this pull request
Aug 14, 2025
https://bugs.webkit.org/show_bug.cgi?id=297268 Reviewed by Rupin Mittal. Implement whatwg/cookiestore#283 with tests upstreamed at web-platform-tests/wpt#54264 Canonical link: https://commits.webkit.org/298681@main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For whatwg/cookiestore#283.