-
-
Notifications
You must be signed in to change notification settings - Fork 321
Add Playwright CT CSS fixture and update entry patterns #1252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| body { | ||
| background-color: #f0f0f0; | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,2 @@ | ||
| // Import styles, initialize component theme here. | ||
| // import '../src/common.css'; | ||
| import './common.css'; | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| import type { IsPluginEnabled, Plugin } from '../../types/config.js'; | ||
| import { hasDependency } from '../../util/plugin.js'; | ||
| import { entry, resolveConfig } from '../playwright/index.js'; | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We could still re-use this |
||
| import { resolveConfig } from '../playwright/index.js'; | ||
|
|
||
| // https://playwright.dev/docs/test-components | ||
|
|
||
|
|
@@ -10,7 +10,9 @@ const enablers = [/^@playwright\/experimental-ct-/]; | |
|
|
||
| const isEnabled: IsPluginEnabled = ({ dependencies }) => hasDependency(dependencies, enablers); | ||
|
|
||
| const config = ['playwright-ct.config.{js,ts}', 'playwright/index.{js,ts,jsx,tsx}']; | ||
| const config = ['playwright-ct.config.{js,ts}']; | ||
|
|
||
| const entry = ['**/*.@(spec|test).?(c|m)[jt]s?(x)', 'playwright/index.{js,ts,jsx,tsx}'] | ||
clickCA marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| export default { | ||
| title, | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,6 +13,7 @@ test('Find dependencies with the Playwright for components plugin', async () => | |
|
|
||
| assert.deepEqual(counters, { | ||
| ...baseCounters, | ||
| files: 1, | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would not expect this change. Maybe it's because this fixture does not have a |
||
| devDependencies: 0, | ||
| unlisted: 0, | ||
| processed: 3, | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh interesting this was already here 😅