Skip to content

Conversation

@IlyasLebleu
Copy link

No description provided.

}
bestSources += '}}';
text += bestSources;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without a signature, it won't be touched by archiving bots, and cannot be replied to via the reply button.

sourcesExist = (sng[0] == "GNG") && (ui.bestsourcesInput1.getValue() || ui.bestsourcesInput2.getValue() || ui.bestsourcesInput3.getValue());

if (sourcesExist) {
text = text.replace(/\{\{Best sources\|(.*?)\}\}/g, '');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this really need to be on the talk page? I think we should just keep it on the draft page where all other submission-related comments go. Reviewers don't look at talk pages. Some character limits can be put in place to ensure the comments don't become too big.

}

header += '{{afc comment|1=';
header += 'I believe this article meets ' + sng + '. ';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's putting words in the user's mouth, since nowhere they say that explicitly.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@siddharthvp What would be a better way to phrase it? Perhaps saying it in the third person would be better?

"orestopic-placeholder": "Start typing to search for topics ...",
"orestopic-label": "Topic classifiers",
"orestopic-helptip": "Pick the topic areas that are relevant",
"bestsources-placeholder1": "Enter your first source here",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be more clear on what to enter: we need either the url or a brief citation for offline sources (without using citation templates).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants