-
Notifications
You must be signed in to change notification settings - Fork 4
WP:THREE wizard addition #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| } | ||
| bestSources += '}}'; | ||
| text += bestSources; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without a signature, it won't be touched by archiving bots, and cannot be replied to via the reply button.
| sourcesExist = (sng[0] == "GNG") && (ui.bestsourcesInput1.getValue() || ui.bestsourcesInput2.getValue() || ui.bestsourcesInput3.getValue()); | ||
|
|
||
| if (sourcesExist) { | ||
| text = text.replace(/\{\{Best sources\|(.*?)\}\}/g, ''); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this really need to be on the talk page? I think we should just keep it on the draft page where all other submission-related comments go. Reviewers don't look at talk pages. Some character limits can be put in place to ensure the comments don't become too big.
| } | ||
|
|
||
| header += '{{afc comment|1='; | ||
| header += 'I believe this article meets ' + sng + '. '; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that's putting words in the user's mouth, since nowhere they say that explicitly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@siddharthvp What would be a better way to phrase it? Perhaps saying it in the third person would be better?
| "orestopic-placeholder": "Start typing to search for topics ...", | ||
| "orestopic-label": "Topic classifiers", | ||
| "orestopic-helptip": "Pick the topic areas that are relevant", | ||
| "bestsources-placeholder1": "Enter your first source here", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be more clear on what to enter: we need either the url or a brief citation for offline sources (without using citation templates).
No description provided.