KotlinX.Coroutines 1.4.1 #1050
KotlinX.Coroutines 1.4.1 #1050
Conversation
|
waiting #987 to be merged |
|
Must check possible duplicate: |
moljac
left a comment
moljac
left a comment
There was a problem hiding this comment.
It would be good to prefix nugets/namespaces/assemblies with Xamarin if author is Microsoft.
|
Antonio I had to bind really fast 2 new bindings for 4-5 new AndroidX artifacts ( Would it be possible to add remaining stuff to Kotlin folder? IMO this will be most likely updated all together (though not sure) |
|
I prefer not to put in Kotlin folder KotlinX is released separately. I think it is better to be decoupled. I change rootnamespace and binding namespace. Currently working on sample app (plan to finish it today) |
|
Don't forget nuget packagenames prefix please |
|
OK. I will publish 1.3.4 from other PR and then delete it afterwards. |
…oroutines-1.4.1 # Conflicts: # manifest.yaml
|
Any news on this? 😊 |
|
@moljac can we merge this and publish nugets? |
|
Any news on this? |
jpobst
left a comment
jpobst
left a comment
There was a problem hiding this comment.
Namespace that is not renamed or hidden:
### New Namespace Kotlin.Coroutines.Jvm.Internal
| @@ -0,0 +1,6 @@ | |||
| <metadata> | |||
|
|
|||
| <attr path="/api/package[@name='kotlinx.coroutines.android']" name="managedName">Xamarin.KotlinX.Coroutines.CoroutinesAndroid</attr> | |||
There was a problem hiding this comment.
I think we need to pick a standard capitalization for Kotlinx/KotlinX and be consistent with it.
There was a problem hiding this comment.
Changing all to KotlinX
There was a problem hiding this comment.
Looks like our existing packages have already committed to KotlinX:
https://www.fuget.org/packages/Xamarin.KotlinX.Coroutines.Core/1.3.4
😉
| @@ -0,0 +1,55 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
There was a problem hiding this comment.
I don't think we want to bind these libraries that aren't intended for Android:
- Xamarin.Kotlinx.Coroutines.Core.Jvm
- Xamarin.Kotlinx.Coroutines.Core.Jdk8
- Xamarin.Kotlinx.Coroutines.Core.Reactive
- Xamarin.Kotlinx.Coroutines.Core.Rx2
Today it looks like we only publish 2 packages:
- Xamarin.KotlinX.Coroutines.Core
- Xamarin.KotlinX.Coroutines.CoroutinesAndroid
There was a problem hiding this comment.
Today it looks like we only publish 2 packages:
I think I bound those from Kotlin folder, just minimal dependencies I needed for GPS-FB-MLKit.
So, deleting or not publishing other packages?
There was a problem hiding this comment.
Dependencies listed:
-
kotlinx-coroutines-android-
dependencies
-
kotlin-stdlib -
kotlinx-coroutines-core-jvm
-
-
-
kotlinx-coroutines-core-jvm-
dependencies
-
kotlin-stdlib -
kotlin-stdlib-common
-
-
-
kotlinx-coroutines-jdk8-
dependencies
-
kotlin-stdlib -
kotlinx-coroutines-core-jvm
-
-
-
kotlinx-coroutines-reactive-
dependencies
-
kotlin-stdlib -
kotlinx-coroutines-core-jvm -
org.reactivestreams:reactive-streams
-
-
-
kotlinx-coroutines-rx2-
dependencies
-
kotlin-stdlib -
kotlinx-coroutines-core-jvm -
io.reactivex.rxjava2:rxjava -
kotlinx-coroutines-reactive
-
-
Already bound:
Kotlin.StdLibXamarin.Android.ReactiveStreamsRxJava
So seem like those could be used on Android and it
|
because of conflicts manual merge had to be performed. branch: https://github.com/xamarin/XamarinComponents/tree/antonioseric-KotlinxCoroutines-1.4.1 PR: #1155 |
|
closing this PR. Published from other PR/branch after manual merging |
5 participants
No description provided.