Add ability to propagate RetrySettings #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgvoleg
force-pushed
the
retry_settings
branch
from
09553e2 to
919ff6c
Compare
There was a problem hiding this comment.
Pull request overview
This PR adds the ability to propagate RetrySettings from database connections to cursor operations in the YDB DBAPI implementation. The RetrySettings object is now initialized in connections, exposed via getter/setter methods, passed to cursors during creation, and properly utilized when invoking retry operations. This enables users to customize retry behavior for their database operations.
- Added
retry_settingsproperty toBaseConnectionwith corresponding getter/setter methods - Updated both
CursorandAsyncCursorconstructors to accept and storeretry_settings - Propagated
retry_settingsto allretry_operation_syncandretry_operation_asynccalls
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ydb_dbapi/connections.py | Added retry_settings initialization in BaseConnection.__init__, implemented getter/setter methods (set_ydb_retry_settings/get_ydb_retry_settings), and updated cursor creation in both Connection and AsyncConnection to pass retry_settings |
| ydb_dbapi/cursors.py | Updated Cursor and AsyncCursor constructors to accept and store retry_settings parameter, and propagated it to all retry_operation_sync and retry_operation_async calls in query execution methods |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.